[ruby-core:119724] [Ruby master Bug#20863] `zlib.c` calls `rb_str_set_len` and `rb_str_modify_expand`(and others) without holding the GVL.
From:
"ioquatix (Samuel Williams) via ruby-core" <ruby-core@...>
Date:
2024-11-05 10:47:32 UTC
List:
ruby-core #119724
Issue #20863 has been reported by ioquatix (Samuel Williams). ---------------------------------------- Bug #20863: `zlib.c` calls `rb_str_set_len` and `rb_str_modify_expand`(and others) without holding the GVL. https://bugs.ruby-lang.org/issues/20863 * Author: ioquatix (Samuel Williams) * Status: Open * Backport: 3.1: UNKNOWN, 3.2: UNKNOWN, 3.3: UNKNOWN ---------------------------------------- I was investigating some problems with `zlib.c` and GVL, and noticed that it releases the GVL, but still calls various `rb_` functions. According to my understanding, this is invalid. I propose the following fix: https://github.com/ruby/zlib/pull/88 In addition, I think we should add more checks for this, in other words, we should add something like this to functions which are expected to only be called while the GVL is held: ```c RUBY_ASSERT(ruby_thread_has_gvl_p()) ``` I made a simple PR to demonstrate the change: https://github.com/ruby/ruby/pull/11975 While the current implementation is internal only (`ruby_thread_has_gvl_p` is not public interface), I think we should add this interface as a public macro, e.g. `RUBY_DEBUG_ASSERT_GVL` or something like that. This macro should be added to all methods that require the GVL in order to diagnose these issues. -- https://bugs.ruby-lang.org/ ______________________________________________ ruby-core mailing list -- [email protected] To unsubscribe send an email to [email protected] ruby-core info -- https://ml.ruby-lang.org/mailman3/lists/ruby-core.ml.ruby-lang.org/
