[ruby-core:96418] [Ruby master Feature#16289] Reduce duplicated warnings for the change of Ruby 3 keyword arguments
From:
ruby-core@...
Date:
2019-12-23 07:37:33 UTC
List:
ruby-core #96418
Issue #16289 has been updated by marcandre (Marc-Andre Lafortune).
I'm glad this was merged in, but disappointed the error message still doesn't mention that this is a deprecation warning.
Wouldn't it be cleared with https://github.com/ruby/ruby/pull/2776 ?
----------------------------------------
Feature #16289: Reduce duplicated warnings for the change of Ruby 3 keyword arguments
https://bugs.ruby-lang.org/issues/16289#change-83342
* Author: mame (Yusuke Endoh)
* Status: Closed
* Priority: Normal
* Assignee:
* Target version:
----------------------------------------
## Problem
Currently, the interpreter emits 200 lines of warnings against the following program.
```ruby
def foo(**opt); end
100.times { foo({kw:1}) }
```
```
$ ./miniruby -e 'def foo(**opt); end; 100.times { foo({kw:1}) }'
-e:1: warning: The last argument is used as the keyword parameter
-e:1: warning: for `foo' defined here
-e:1: warning: The last argument is used as the keyword parameter
-e:1: warning: for `foo' defined here
-e:1: warning: The last argument is used as the keyword parameter
-e:1: warning: for `foo' defined here
...
```
In theory, the warnings are not harmful because they don't stop or interfere the execution. But in practice, I'm afraid if they are annoying because they flush all console logs away.
I think that the warning is not needed if the call is already warned.
## Proposal
How about limiting the count of warnings to at most once for each pair of caller and callee?
I've created [a pull request](https://github.com/ruby/ruby/pull/2458). It records all pairs of caller position and callee iseq when emitting a warning, and suppress the warning if the same pair of caller and callee is already warned.
What do you think?
--
https://bugs.ruby-lang.org/
Unsubscribe: <mailto:[email protected]?subject=unsubscribe>
<http://lists.ruby-lang.org/cgi-bin/mailman/options/ruby-core>
