[#97678] [Ruby master Feature#16752] :private param for const_set — bughitgithub@...
Issue #16752 has been reported by bughit (bug hit).
5 messages
2020/04/02
[ruby-core:97907] [Ruby master Bug#16792] Make Mutex held per Fiber instead of per Thread
From:
eregontp@...
Date:
2020-04-16 09:01:59 UTC
List:
ruby-core #97907
Issue #16792 has been reported by Eregon (Benoit Daloze). ---------------------------------------- Bug #16792: Make Mutex held per Fiber instead of per Thread https://bugs.ruby-lang.org/issues/16792 * Author: Eregon (Benoit Daloze) * Status: Open * Priority: Normal * Backport: 2.5: UNKNOWN, 2.6: UNKNOWN, 2.7: UNKNOWN ---------------------------------------- Currently, Mutex in CRuby is held per Thread. In JRuby and TruffleRuby, Mutex is held per Fiber (because it's simply easier implementation-wise). While a user could theoretically notice the difference, it seems extremely uncommon in practice (probably incorrect synchronization). The usage pattern for a Mutex is using #synchronize or lock+unlock. Such a pattern protects/surrounds a region of code using some resource, and such a region of code is always on the same Fiber since it's on a given Ruby "stack". With #16786 it becomes more relevant to have Mutex held Fiber, otherwise Mutex#lock basically would hurt scalability significantly. This means, if a Fiber does Mutex#lock and it's already held by another Fiber of the same Thread, and the Thread#scheduler is enabled, instead of just raising an error, or preventing switching entirely until #unlock, we would just go to the scheduler and schedule another Fiber (for instance, the one holding that Mutex, or any other ready to be run Fiber). This is not a new idea and in fact Crystal already does this with its non-blocking Fibers, which is very similar with #16786: https://github.com/crystal-lang/crystal/blob/612825a53c831ce7d17368c8211342b199ca02ff/src/mutex.cr#L72 Mutex#lock is just like other blocking operations, so let's make it so building on #16786. I believe it's the natural and intuitive thing to do for Fiber concurrency with a scheduler. Queue#pop and SizedQueue#push could be other candidates to handle in a similar way. Here is an early commit to make Mutex held per Fiber, it's quite trivial as you can see: https://github.com/ruby/ruby/compare/master...eregon:mutex-per-fiber It passes test-all and test-spec. -- https://bugs.ruby-lang.org/ Unsubscribe: <mailto:[email protected]?subject=unsubscribe> <http://lists.ruby-lang.org/cgi-bin/mailman/options/ruby-core>
