[#97678] [Ruby master Feature#16752] :private param for const_set — bughitgithub@...
Issue #16752 has been reported by bughit (bug hit).
5 messages
2020/04/02
[ruby-core:98048] [Ruby master Feature#8215] Support accessing Fiber-locals and backtraces for a Fiber
From:
eregontp@...
Date:
2020-04-24 08:37:55 UTC
List:
ruby-core #98048
Issue #8215 has been updated by Eregon (Benoit Daloze).
@ioquatix Please create a separate feature ticket for `Fiber#backtrace`, as already asked by nobu in https://bugs.ruby-lang.org/issues/8215#note-5
I'd like to keep the discussion here about Fiber locals, not mix it with an unrelated method.
A separate ticket is better so e.g. the discussion is clear and focused, that ticket can be closed when implemented, the reference from NEWS will be much less confusing, etc.
Back to the fiber locals discussion:
> Thread safety is not my concern, the function can be marked as thread unsafe, and maybe we can add detection of this and warn against it.
It's of course unacceptable if a Ruby implementation behaves unsafely (e.g., crashes or loses fiber local variable) for this, so it is a relevant concern for this issue.
Another one is this needs `Fiber.current`, which is only available after `require "fiber"`.
I think that could be confusing, so I'd suggest making `Fiber.current` always available if we go that way.
I think `Fiber[:foo]` and `Fiber[:foo] = ...` is a better API because it avoids this problem entirely, and gives the possibility to have clean Thread and Fiber locals APIs.
We could also add a check in `Fiber#[]` but that would read the current Fiber a second time, and move it to a runtime error instead of simply not being possible with `Fiber[:foo]`.
Maybe the check is not so important since I guess `Thread#[]` will still need to work for a long while, but for new APIs I think a good safe design is worth considering.
If you think we need the ability to access another Fiber's locals, could you show some examples?
----------------------------------------
Feature #8215: Support accessing Fiber-locals and backtraces for a Fiber
https://bugs.ruby-lang.org/issues/8215#change-85277
* Author: halorgium (Tim Carey-Smith)
* Status: Assigned
* Priority: Normal
* Assignee: ioquatix (Samuel Williams)
----------------------------------------
=begin
As part of debugging celluloid, I have been wanting to diagnose where the Fibers are running and their various locals.
I would expect the following to work.
Thread.current[:key] = "outside"
fiber = Fiber.new do
Thread.current[:key] = "inside"
Fiber.yield
end
fiber.resume
fiber[:key] == "inside" # true
fiber.backtrace # ...
I also wonder whether (({Fiber#[]})) should be implemented, so (({Fiber.current[:key]})) is possible.
For reference, here is the issue on the rubinius issue tracker: ((<"github/rubinius/rubinius/2200"|URL:https://github.com/rubinius/rubinius/issues/2200>))
=end
---Files--------------------------------
0001-cont.c-fiber-local-accessors.patch (2.94 KB)
--
https://bugs.ruby-lang.org/
Unsubscribe: <mailto:[email protected]?subject=unsubscribe>
<http://lists.ruby-lang.org/cgi-bin/mailman/options/ruby-core>
