➜
This issue tracker has been migrated to GitHub,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2020-07-16 22:12 by alex.gronholm, last changed 2022-04-11 14:59 by admin.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| bug.py | alex.gronholm, 2020-07-16 22:12 | Script to reproduce the error | ||
| Pull Requests | |||
|---|---|---|---|
| URL | Status | Linked | Edit |
| PR 21595 | merged | alex.gronholm, 2020-07-22 22:22 | |
| PR 21603 | merged | miss-islington, 2020-07-23 19:45 | |
| Messages (7) | |||
|---|---|---|---|
| msg373777 - (view) | Author: Alex Grönholm (alex.gronholm) * | Date: 2020-07-16 22:12 | |
Unlike with all the other sock_* functions, sock_accept() only removes the reader on the server socket when the socket becomes available for reading (ie. when there's an incoming connection). If the operation is cancelled instead, the reader is not removed. If then the server socket is closed and a new socket is created which has the same file number and it is used for a socket operation, it will cause a FileNotFoundError because the event loop thinks it has this fd registered but the epoll object does not agree since all closed sockets are automatically removed from it. The attached script reproduces the problem on Fedora Linux 32 (all relevant Python versions), but not on Windows (on any tested Python versions from 3.6 to 3.8). |
|||
| msg373840 - (view) | Author: Alex Grönholm (alex.gronholm) * | Date: 2020-07-17 17:31 | |
This bug is the same as https://bugs.python.org/issue30064 except for sock_accept(). |
|||
| msg374110 - (view) | Author: Yury Selivanov (yselivanov) *  |
Date: 2020-07-22 21:06 | |
Alex, do you want to submit a PR? |
|||
| msg374111 - (view) | Author: Alex Grönholm (alex.gronholm) * | Date: 2020-07-22 21:10 | |
Sure, it should be a rather straightforward fix. I have to check if the tests for the related methods test for proper cancellation semantics. It should be even faster if they do. |
|||
| msg374112 - (view) | Author: Alex Grönholm (alex.gronholm) * | Date: 2020-07-22 21:21 | |
Looks like they do – fantastic! |
|||
| msg374145 - (view) | Author: Yury Selivanov (yselivanov) * |
Date: 2020-07-23 19:45 | |
New changeset 0dd98c2d00a75efbec19c2ed942923981bc06683 by Alex Grönholm in branch 'master': bpo-41317: Remove reader on cancellation in asyncio.loop.sock_accept() (#21595) https://github.com/python/cpython/commit/0dd98c2d00a75efbec19c2ed942923981bc06683 |
|||
| msg374146 - (view) | Author: miss-islington (miss-islington) | Date: 2020-07-23 20:02 | |
New changeset 4ff8e5ba4fef7f7d0fc1b1872ccb91bc3fd1294d by Miss Islington (bot) in branch '3.9': bpo-41317: Remove reader on cancellation in asyncio.loop.sock_accept() (GH-21595) https://github.com/python/cpython/commit/4ff8e5ba4fef7f7d0fc1b1872ccb91bc3fd1294d |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:59:33 | admin | set | github: 85489 |
| 2020-07-23 20:02:57 | miss-islington | set | messages: + msg374146 |
| 2020-07-23 19:45:29 | miss-islington | set | nosy:
+ miss-islington pull_requests: + pull_request20742 |
| 2020-07-23 19:45:17 | yselivanov | set | messages: + msg374145 |
| 2020-07-22 22:22:24 | alex.gronholm | set | keywords:
+ patch stage: patch review pull_requests: + pull_request20734 |
| 2020-07-22 21:21:15 | alex.gronholm | set | messages: + msg374112 |
| 2020-07-22 21:10:11 | alex.gronholm | set | messages: + msg374111 |
| 2020-07-22 21:06:19 | yselivanov | set | messages: + msg374110 |
| 2020-07-17 17:31:48 | alex.gronholm | set | messages: + msg373840 |
| 2020-07-16 22:12:05 | alex.gronholm | create | |
