Code browser: HTTP code 404 when I click on a submodule directory which is the wiki repository of the project #217

New issue

ncc1988 · 2020-07-09T16:59:32+02:00

ncc1988 commented

2020-07-09 16:59:32 +02:00

In one project, I added the wiki repository as submodule in the main repository to have a convenient way of updating the documentation. When I browse the code in the code view and click on the directory that has the wiki repository as submodule, I get an 404 error. This is because the wiki repository is not a "real" project of its own.

This is the project: https://codeberg.org/moenavigator/moenavigatorengine
The "doc" folder is the wiki repository as submodule.

A solution to prevent such 404 errors could be to check if the submodule URL is basically the URL of the project repository with ".wiki" added to it. In that case, the code browser could redirect to the project wiki. In the case that a project added the URL of another project on the same domain the code browser could redirect to the other project's wiki.

In one project, I added the wiki repository as submodule in the main repository to have a convenient way of updating the documentation. When I browse the code in the code view and click on the directory that has the wiki repository as submodule, I get an 404 error. This is because the wiki repository is not a "real" project of its own. This is the project: https://codeberg.org/moenavigator/moenavigatorengine The "doc" folder is the wiki repository as submodule. A solution to prevent such 404 errors could be to check if the submodule URL is basically the URL of the project repository with ".wiki" added to it. In that case, the code browser could redirect to the project wiki. In the case that a project added the URL of another project on the same domain the code browser could redirect to the other project's wiki.

hw added the

bug

s/Forgejo

labels

2020-07-09 19:12:11 +02:00

fnetX commented

2021-02-27 19:24:22 +01:00

I tried to reproduce on https://try.gitea.io/fnetx/gitea-submodule-thing/wiki to report upstream, but I cannot even clone the wiki. Look at the provided link it isn't even displaying the wiki git url.

cc @6543 is there a change coming or is it a bug at try.gitea.io?

I tried to reproduce on https://try.gitea.io/fnetx/gitea-submodule-thing/wiki to report upstream, but I cannot even clone the wiki. Look at the provided link it isn't even displaying the wiki git url. cc @6543 is there a change coming or is it a bug at try.gitea.io?

👍 1

6543 commented

2021-04-08 15:52:23 +02:00

still on my backlock ...

resectio commented

2022-02-04 08:52:03 +01:00

I tested it out again and since the problem still occurs, I decided to forward this issue to upstream: https://github.com/go-gitea/gitea/issues/18590

To test it out use either of the following links:

https://try.gitea.io/schorsch/test-wiki-submodule
https://codeberg.org/moenavigator/moenavigatorengine (the ./doc folder)

I tested it out again and since the problem still occurs, I decided to forward this issue to upstream: https://github.com/go-gitea/gitea/issues/18590 To test it out use either of the following links: - https://try.gitea.io/schorsch/test-wiki-submodule - https://codeberg.org/moenavigator/moenavigatorengine (the ./doc folder)

👍 1

resectio added the

upstream

label

2022-02-04 08:52:12 +01:00

resectio commented

2022-03-23 19:19:08 +01:00

The issue should have been fixed by upstream in this PR: https://github.com/go-gitea/gitea/pull/18831. The functionality will be implemented with the next release

resectio added a new dependency

2022-03-23 19:19:28 +01:00

#579 Gitea v1.17

resectio referenced this issue

2022-03-23 20:16:09 +01:00

Gitea v1.17 #579

6543 self-assigned this

2022-05-15 21:04:04 +02:00

6543 closed this issue

2022-08-09 14:19:53 +02:00

Sign in to join this conversation.