add GitHub and GitLab as Oauth2 sources #225

New issue

6543 · 2020-07-27T21:07:55+02:00

6543 commented

2020-07-27 21:07:55 +02:00

this would make migration from GitHub/GitLab eaven easyer: user who have created an accounton Codeberg and linked this one with a GitHub account later, will automaticaly take over the ownership of issues/pulls/comments on repos witch had used the build-in Migration tool.

👍 2

ashimokawa commented

2020-07-27 21:25:59 +02:00

@6543

Personally I would like to support linking the account for issue/pulls/comments migration.

But I would like to do it without enabling "login/register with github". Accounts created that way behaved weird in our and tests by @davidak .

It that possible?

@6543 Personally I would like to support linking the account for issue/pulls/comments migration. But I would like to do it **without** enabling "login/register with github". Accounts created that way behaved weird in our and tests by @davidak . It that possible?

6543 commented

2020-07-27 21:37:16 +02:00

Accounts created that way behaved weird

Noticed too, there is somehow a diffrence if you create fia github or link an account afterwards - but didn't digged into this rabit hole jet

... posible without enabling ... github login ...

sadly: NO

this is the general problem of how to make sure that someone realy own the account X on platform Y

> Accounts created that way behaved weird Noticed too, there is somehow a diffrence if you create fia github or link an account afterwards - but didn't digged into this rabit hole jet > ... posible without enabling ... github login ... sadly: NO this is the general problem of how to make sure that someone realy own the account X on platform Y

ashimokawa commented

2020-07-27 21:42:27 +02:00

Noticed too, there is somehow a diffrence if you create fia github or link an account afterwards - but didn’t digged into this rabit hole jet

Yes, this is what I mean, I would like to disable "create via github" but keep "link account afterwards". A patch for gitea/codeberg would be neccessary I guess.

> Noticed too, there is somehow a diffrence if you create fia github or link an account afterwards - but didn’t digged into this rabit hole jet Yes, this is what I mean, I would like to disable "create via github" but keep "link account afterwards". A patch for gitea/codeberg would be neccessary I guess.

👍 1

6543 commented

2020-07-27 22:05:46 +02:00

@ashimokawa if we like to get it with v1.12.x I think a patch will be needed :/

6543 commented

2020-07-27 22:14:00 +02:00

upstream issue: https://github.com/go-gitea/gitea/issues/12342

6543 added the

s/Forgejo

upstream

enhancement

labels

2021-02-27 00:40:10 +01:00

6543 self-assigned this

2021-05-07 15:53:51 +02:00

6543 commented

2021-05-08 21:28:23 +02:00

upstream pull: https://github.com/go-gitea/gitea/pull/15795

❤️ 2

6543 commented

2021-05-15 20:12:40 +02:00

ok did we come to the conclusion it's working fine ...?

can be tested on https://codeberg-test.org/ atm :D

ok did we come to the conclusion it's working fine ...? can be tested on https://codeberg-test.org/ atm :D

fnetX commented

2021-05-15 20:56:00 +02:00

Think so, missing thing is some explanation in the docs on how to connect?

6543 commented

2021-05-15 21:01:18 +02:00

well thinks so,

jut the hint we have to make sure...:

Github oauth authentification source has te be named github
Gitlab oauth authentification source has te be named gitlab

well thinks so, jut the hint we have to make sure...: * Github oauth authentification source has te be named `github` * Gitlab oauth authentification source has te be named `gitlab`

6543 commented

2021-05-27 20:42:49 +02:00

INFO: Codeberg/gitea@0d3874b691 will make it posible, on next deploy 🚀

INFO: https://codeberg.org/Codeberg/gitea/commit/0d3874b6914e512eb9a9b5c48888f6a9c023a2f8 will make it posible, on next deploy :rocket:

davidak commented

2021-07-09 07:41:00 +02:00

I tried to test this and failed, maybe at the CAPTCHA. #483

This would help a lot to convince projects to migrate to codeberg as their users can still contribute easily with github/gitlab account.

I tried to test this and failed, maybe at the CAPTCHA. https://codeberg.org/Codeberg/Community/issues/483 This would help a lot to convince projects to migrate to codeberg as their users can still contribute easily with github/gitlab account.

fnetX commented

2021-07-09 13:24:41 +02:00

I don't know if the login sources are setup properly yet or maybe broken? Testing this is highly appreciated before we rollout to prod, I'm not sure about the current state.

We'll hit this issue up as soon as we get to this topic again ...

I don't know if the login sources are setup properly yet or maybe broken? Testing this is highly appreciated before we rollout to prod, I'm not sure about the current state. We'll hit this issue up as soon as we get to this topic again ...

6543 commented

2021-07-09 15:36:59 +02:00

It should work all fine?

What do you rever to @fnetX ?

It should work all fine? What do you rever to @fnetX ?

davidak commented

2021-07-10 11:26:11 +02:00

It should work all fine?

have you tested it? shouldn't take too long

it fails for me

steps to reproduce:

don't have an account on the test instance
open https://codeberg-test.org/user/login
click Sign In With GitHub
the page "Link to Existing Account" (https://codeberg-test.org/user/link_account) opens
i don't have an account, so i input random characters and click Link account
then i get to the page https://codeberg-test.org/user/link_account_signin where i click the option Register New Account (i don't see it on the first site)
i input my user name (davidak), e-mail und captcha and click "Complete Account"
i get a white page with the text "Forbidden"

the browser console (Chromium 91.0.4472.114) says:

Error with Permissions-Policy header: Unrecognized feature: 'interest-cohort'.
link_account_signup:1 POST https://codeberg-test.org/user/link_account_signup 403

here is a video that shows the issue and how it works on https://try.gitea.io/

https://peertube.social/videos/watch/eaf0278a-f14c-4018-83cc-0c2a3706dea6

>It should work all fine? have you tested it? shouldn't take too long it fails for me steps to reproduce: 0. don't have an account on the test instance 1. open https://codeberg-test.org/user/login 2. click *Sign In With GitHub* 3. the page "Link to Existing Account" (https://codeberg-test.org/user/link_account) opens 4. i don't have an account, so i input random characters and click *Link account* 5. then i get to the page https://codeberg-test.org/user/link_account_signin where i click the option *Register New Account* (i don't see it on the first site) 6. i input my user name (davidak), e-mail und captcha and click "Complete Account" 7. i get a white page with the text "Forbidden" the browser console (Chromium 91.0.4472.114) says: > Error with Permissions-Policy header: Unrecognized feature: 'interest-cohort'. > link_account_signup:1 POST https://codeberg-test.org/user/link_account_signup 403 here is a video that shows the issue and how it works on https://try.gitea.io/ https://peertube.social/videos/watch/eaf0278a-f14c-4018-83cc-0c2a3706dea6

fnetX commented

2021-07-10 12:48:46 +02:00

Yeah this isn't the supposed workflow. It's not described, because it's not on prod yet.

You have to register an account first, then sign-in with GitHub and link it.

Maybe this can be changed, but it's not the way it's supposed to work.

It's at least a bug that you see the sign-up tab after entering non-working credentials ...

Yeah this isn't the supposed workflow. It's not described, because it's not on prod yet. You have to register an account first, then sign-in with GitHub and link it. Maybe this can be changed, but it's not the way it's supposed to work. It's at least a bug that you see the sign-up tab after entering non-working credentials ...

Ghost commented

2021-07-10 22:19:18 +02:00

whats the point in "sign in with github" if i need to register locally anyway?

👍 1

fnetX commented

2021-07-10 23:12:53 +02:00

You can link your account with migrated content. The issues do not longer show some random GitHub user, but your account etc ...

If possible, I personally don't object to logging in with GitHub, but we had issues with having access to the users mail address IIRC ...

You can link your account with migrated content. The issues do not longer show some random GitHub user, but your account etc ... If possible, I personally don't object to logging in with GitHub, but we had issues with having access to the users mail address IIRC ...

6543 commented

2021-07-10 23:50:57 +02:00

hmm https://codeberg-test.org/user/link_account_signin should return 404 or better redirect to normal signup

hmm `https://codeberg-test.org/user/link_account_signin` should return 404 or better redirect to normal signup

6543 commented

2021-09-11 22:08:13 +02:00

done 🚀

👍 2

6543 closed this issue

2021-09-11 22:08:13 +02:00

davidak commented

2021-09-12 03:45:20 +02:00

It works now to link an existing account.

Tested on https://codeberg-test.org/.

Would be great if one could create an account just from GitHub login. So UX would be:

Click "Login with GitHub"
Allow to use user data from GitHub
You are logged in with your new account

It uses the e-mail github has and you can reset your password with that address if github would disappear.

It works now to link an existing account. Tested on https://codeberg-test.org/. Would be great if one could create an account just from GitHub login. So UX would be: 1. Click "Login with GitHub" 2. Allow to use user data from GitHub 2. You are logged in with your new account It uses the e-mail github has and you can reset your password with that address if github would disappear.

6543 commented

2021-09-12 04:30:35 +02:00

@davidak another issue - "enable auto account creation on oauth login" ... ;)

👍 1

davidak referenced this issue

2021-09-12 18:17:59 +02:00

enable auto account creation on oauth login #518

Sign in to join this conversation.

No milestone

No project

No assignees

5 participants

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Codeberg/Community#225

Rows
Columns