No option to make wikis editable for all users of codeberg (not only the project members) #28

New issue

I took the original PR, and updated it to the most recent codebase, and made it work not only for wikis owned by organizations, but by users too. The work in progress code is here.

Apart from code formatting, there are a few issues to iron out:

I need to review the review notes on the Gitea PR too, and adjust the code accordingly
- Rather than a "globally_writeable" flag, repo_unit should have a "default permissions" column, with "none", "read", or "write" as possible options (defaulting to read). The UI would remain the same, and wouldn't expose "none" yet, just a "globally writeable" toggle for the wiki. The three-value column is more future proof, is all.
This needs a migration, adding the globally_writeable flag (or default_permissions) to repo_unit.
The permission check for user repos isn't great, it only works if there's only one repo unit marked globally writeable (which is the case now, but may not remain so in the future), that code needs a bit of a cleanup
Localization is borked
The option should only be available for public repos
Needs tests

Nevertheless, it's looking good, and I will be submitting a PR most likely later today.

I took the original PR, and updated it to the most recent codebase, and made it work not only for wikis owned by organizations, but by users too. The work in progress code is [here](https://codeberg.org/algernon/forgejo/src/branch/f/world-editable-wiki). Apart from code formatting, there are a few issues to iron out: - [x] I need to review the review notes on the Gitea PR too, and adjust the code accordingly - [x] Rather than a "globally_writeable" flag, `repo_unit` should have a "default permissions" column, with "none", "read", or "write" as possible options (defaulting to read). The UI would remain the same, and wouldn't expose "none" yet, just a "globally writeable" toggle for the wiki. The three-value column is more future proof, is all. - [x] This needs a migration, adding the `globally_writeable` flag (or `default_permissions`) to `repo_unit`. - [x] The permission check for user repos isn't great, it only works if there's only one repo unit marked globally writeable (which is the case *now*, but may not remain so in the future), that code needs a bit of a cleanup - [x] Localization is borked - [x] The option should only be available for public repos - [x] Needs tests Nevertheless, it's looking good, and I will be submitting a PR most likely later today.

algernon referenced this issue from a commit

2023-12-20 13:31:58 +01:00

Optionally allow anyone to edit Wikis

algernon referenced this issue from a commit

2023-12-20 17:58:16 +01:00

Optionally allow anyone to edit Wikis

algernon referenced this issue from a commit

2023-12-20 19:16:43 +01:00

Optionally allow anyone to edit Wikis

algernon referenced this issue from a commit

2023-12-20 19:17:30 +01:00

Optionally allow anyone to edit Wikis