Paging of star list does not work #345

Closed
opened 2020-12-01 19:41:32 +01:00 by jannis · 4 comments
Image

The second page of the star list shows the same people as the first one, look at: https://codeberg.org/Codeberg/Community/stars

and: https://codeberg.org/Codeberg/Community/stars?page=2

They're the same. Probably a gitea issue, should I create an issue there?

The second page of the star list shows the same people as the first one, look at: https://codeberg.org/Codeberg/Community/stars and: https://codeberg.org/Codeberg/Community/stars?page=2 They're the same. Probably a gitea issue, should I create an issue there?
Image
Owner

The bug is that ALL stars are displayed on one page, no matter which page, there seems to be no limit :O

Yes this is an upstream bug! Number of pages calculated correctly but no paging :D

https://codeberg.org/Freeyourgadget/Gadgetbridge/stars

The bug is that ALL stars are displayed on one page, no matter which page, there seems to be no limit :O Yes this is an upstream bug! Number of pages calculated correctly but no paging :D https://codeberg.org/Freeyourgadget/Gadgetbridge/stars
Image
Owner

Reported upstream. I had a quick look but did not find the code to be honest...

https://github.com/go-gitea/gitea/issues/14553

Reported upstream. I had a quick look but did not find the code to be honest... https://github.com/go-gitea/gitea/issues/14553
Image
FIX: https://github.com/go-gitea/gitea/pull/14556
Image
Owner

@6543

Perfect, thank you!

Deployed and tested working!

@6543 Perfect, thank you! Deployed and tested working!
Sign in to join this conversation.
No milestone
No project
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Codeberg/Community#345
No description provided.