Sticky the edit button and formatting tools of the wiki #533

New issue

v4vachan · 2021-10-27T11:20:29+02:00

v4vachan commented

2021-10-27 11:20:29 +02:00

I use the codeberg wiki a lot. But I wish the formatting tools would stick with the header so I won't have to scroll all the way up to edit the page or select a formatting option.

fnetX added the

s/Forgejo

contributions welcome

enhancement

labels

2021-11-16 01:05:38 +01:00

martijndeb commented

2022-01-14 14:50:25 +01:00

I'm not sure how to contribute, but I am able to do some frontend dev in the browser :').

The class editor-toolbar needs to become position: sticky, with a top of 1px (on 0 it won't work because of inheritance), with a z-index high enough to make it visible (200 works).

It's then transparant, so it would need a background, and the bottom border should be added.

Adding a bottom border makes it before becoming sticky a double one because the codemirror is styled to have borders all around, so the CodeMirror class should remove it's top border, because the editor toolbar has it in it's bottom.

Long story short, if someone adds this to codeberg.css it would work;

.editor-toolbar {
	position: sticky;
	top: 1px;
	z-index: 200;
	background: var(--color-body);
	border-bottom: 1px solid var(--color-secondary);
}

.CodeMirror {
	border-top: 0;
}

I'm not sure how to contribute, but I am able to do some frontend dev in the browser :'). The class editor-toolbar needs to become position: sticky, with a top of 1px (on 0 it won't work because of inheritance), with a z-index high enough to make it visible (200 works). It's then transparant, so it would need a background, and the bottom border should be added. Adding a bottom border makes it before becoming sticky a double one because the codemirror is styled to have borders all around, so the CodeMirror class should remove it's top border, because the editor toolbar has it in it's bottom. Long story short, if someone adds this to codeberg.css it would work; ```css .editor-toolbar { position: sticky; top: 1px; z-index: 200; background: var(--color-body); border-bottom: 1px solid var(--color-secondary); } .CodeMirror { border-top: 0; } ```

bacon-ipsum-position-sticky.png

142 KiB

fnetX commented

2022-01-14 15:17:04 +01:00

This should ideally go into upstream Gitea, we want to avoid codeberg-specific patches where possible.

martijndeb commented

2022-01-14 16:53:10 +01:00

@fnetX if they're willing to accept it, I've done my first PR on gitea now, including another issue in their tracker related to sticky scrolling.

https://github.com/go-gitea/gitea/pull/18271

@fnetX if they're willing to accept it, I've done my first PR on gitea now, including another issue in their tracker related to sticky scrolling. https://github.com/go-gitea/gitea/pull/18271

v4vachan commented

2022-01-15 18:52:58 +01:00

@fnetX if they're willing to accept it, I've done my first PR on gitea now, including another issue in their tracker related to sticky scrolling.

https://github.com/go-gitea/gitea/pull/18271

Thanks for working on it. Appreciate your work

> @fnetX if they're willing to accept it, I've done my first PR on gitea now, including another issue in their tracker related to sticky scrolling. > > https://github.com/go-gitea/gitea/pull/18271 Thanks for working on it. Appreciate your work

🎉 1

resectio added the

upstream

label

2022-02-03 09:16:46 +01:00

McTom234 referenced this issue from a commit

2022-06-22 12:26:42 +02:00

Limit max-height of CodeMirror editors for issue comment and wiki (#18271)

6543 referenced this issue

2022-08-09 18:53:21 +02:00

Gitea v1.17 #579

6543 closed this issue