UI inconsistencies of the relevancy note box in the explore section #885

Closed
opened 2023-01-10 16:20:34 +01:00 by Gaulm · 4 comments
Image

The relevancy note box in the "Explore" section applies the "blue" class to the div element which seem to paint a blueish color to the background of the component, this may be undesirable depending on the user's theme.
The same box has inconsistency in the corners: rounded on top but sharp on bottom.
I'd also suggest detaching it from the search box, since the corners of the two boxes, being rounded, don't align correctly and don't look particularly good.

After and before in the screenshots, both with Forgejo dark theme.

<!-- NOTE: If your issue is a security concern, please send an email to contact@codeberg.org (and if related to Gitea also to security@gitea.io) instead of opening a public issue. Thank you. Welcome to the Codeberg Community Tracker. This is the right place for bug reports, feature requests and feedback. It's the central place where we track progress and discuss, so please open issues here unless you are sure it's directly related to a specific Codeberg product and only some contributors there need to join the discussion. Easy rule: If you are unsure, report it here. When reporting bugs or asking for features in the software itself, please understand that Codeberg is a fork of Gitea. Please always check upstream (→ see FAQ) if your there is already an open issue. If not, you'd really help us if you could directly get in touch with the maintainers and open an issue here if you think a wider audience should know about that (e. g. when discussing hotfixes, backports or when discussing whether some feature should become part of Gitea or a Codeberg "add-on"). If you don't have a GitHub account, please mention this and we'll gladly forward your report to the Gitea maintainers. Thank you for reporting your findings and giving feedback on Codeberg. ## Some FAQ: ### What does upstream mean? Upstream refers to Gitea, the software Codeberg is built upon. If we ask you if you can report upstream, please visit https://github.com/go-gitea/gitea/issues and check for the bug there and report elsewise. It's usually good if the person interested in a feature or bugfix opens the request to react to questions and join the discussion. We would usually just fire the report, but won't find the time to properly react to that ... **If you do not have a GitHub account**, just tell us and we'll happily forward the report for you. ### I just noticed a typo in the sign_up / sing_up route when regis... No, this is not a typo, but intentional. It was a quick fix to avoid spammers targetting our instance and it actually worked out quite well to rename the route from sign_up to sing_up (few people notice, nice to see you have sharp eyes) ... we might have to take more effective countermeasures in the future, but for now we're actually quite good with that one ... ### How can I help? If you want to help improving Codeberg as a community home for software development, we'll gladly welcome your contribution. Check out the docs about improving Codeberg https://docs.codeberg.org/improving-codeberg/ and have a look at the open issues, especially those that are looking for contribution https://codeberg.org/Codeberg/Community/issues?state=open&labels=105 - some of them don't even require much coding knowledge. We are also happy if you forward bug reports to Gitea if the original author hasn't done that yet or hasn't got a GitHub account. --> The relevancy note box in the "Explore" section applies the "blue" class to the div element which seem to paint a blueish color to the background of the component, this may be undesirable depending on the user's theme.\ The same box has inconsistency in the corners: rounded on top but sharp on bottom.\ I'd also suggest detaching it from the search box, since the corners of the two boxes, being rounded, don't align correctly and don't look particularly good. After and before in the screenshots, both with Forgejo dark theme.
Image
Owner

CC @Gusted

CC @Gusted
Image
Member

I can fix this really easily, I'm just not sure how far upstream I should send the pull request. The template is like this in Gitea so I guess I'll start there.

I can fix this really easily, I'm just not sure how far upstream I should send the pull request. The template is like this in Gitea so I guess I'll start there.
Image
Owner

I can fix this really easily, I'm just not sure how far upstream I should send the pull request. The template is like this in Gitea so I guess I'll start there.

@crystal Feel free to do this in Gitea or in Forgejo and feel free to ping me for a review.

> I can fix this really easily, I'm just not sure how far upstream I should send the pull request. The template is like this in Gitea so I guess I'll start there. @crystal Feel free to do this in Gitea or in Forgejo and feel free to ping me for a review.
Image
Member

it got merged to gitea

it got merged to gitea
Image fnetX closed this issue 2023-01-19 14:41:15 +01:00
Sign in to join this conversation.
No milestone
No project
No assignees
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Codeberg/Community#885
No description provided.