readme TOC links broken #894

Closed
opened 2023-01-15 18:13:42 +01:00 by martianh · 5 comments
Image

i just enabled table of contents on my repo's readme, an org file, but clicking the toc links has no effect. https://codeberg.org/martianh/mastodon.el/src/branch/develop

i just enabled table of contents on my repo's readme, an org file, but clicking the toc links has no effect. https://codeberg.org/martianh/mastodon.el/src/branch/develop
Image
Member

So, turns out this is actually a regression caused by codeberg/forgejo@5f38acd9a0

I devised a way to fix it without JavaScript but my pull request seems to have stalled. I'll send in another pull request that fixes it in anchors.js and see if that goes anywhere. In the meantime you can get around it by refreshing the page after clicking one of the links.

So, turns out this is actually a regression caused by https://codeberg.org/codeberg/forgejo/commit/5f38acd9a08958024e8bbf47bcc482c79d844e44 I devised a way to fix it without JavaScript but [my pull request](https://github.com/go-gitea/gitea/pull/22577) seems to have stalled. I'll send in another pull request that fixes it in `anchors.js` and see if that goes anywhere. In the meantime you can get around it by refreshing the page after clicking one of the links.
Image

my pull request seems to have stalled.

It's approved now.

> [my pull request](https://github.com/go-gitea/gitea/pull/22577) seems to have stalled. It's approved now.
Image
Member
[merged](https://github.com/go-gitea/gitea/pull/22577), [backport pending](https://github.com/go-gitea/gitea/pull/22677)
Image
Member
[backport merged](https://github.com/go-gitea/gitea/pull/22677)
Image
Member

Fixed in Forgejo 1.18.3-0

Fixed in Forgejo 1.18.3-0
Image Ghost referenced this issue from a commit 2023-02-04 18:13:57 +01:00
Image fnetX closed this issue 2023-02-12 15:18:46 +01:00
Sign in to join this conversation.
No milestone
No project
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Codeberg/Community#894
No description provided.