XX Commits to main link broken on releases #967

New issue

Closed

opened 2023-03-21 12:13:02 +01:00 by viceice · 13 comments

viceice commented 2023-03-21 12:13:02 +01:00

Copy link

https://codeberg.org/forgejo-contrib/forgejo-helm/releases/tag/v0.3.3

This works fine on Gitea v1.18.5 and v1.19.0, so must be a Forgejo / Codeberg issue.

The link wrongly targets https://codeberg.org/forgejo-contrib/forgejo-helm/compare/v0.3.3...

So main branch is missing somehow.

https://codeberg.org/forgejo-contrib/forgejo-helm/releases/tag/v0.3.3 This works fine on Gitea v1.18.5 and v1.19.0, so must be a Forgejo / Codeberg issue. The link wrongly targets `https://codeberg.org/forgejo-contrib/forgejo-helm/compare/v0.3.3...` So main branch is missing somehow. 

image.png

41 KiB

viceice commented 2023-03-21 12:15:19 +01:00

Author

Copy link


image.png

45 KiB

oliverpool commented 2023-04-15 16:26:06 +02:00

Copy link

Still present in Forgejo 1.19.1:
https://code.forgejo.org/forgejo/runner/releases

13 commits to since this release

The default branch bame name is missing between "to" and "since" and the link points to a 404.

Still present in Forgejo 1.19.1: https://code.forgejo.org/forgejo/runner/releases > 13 commits to since this release The default branch bame name is missing between "to" and "since" and the link points to a 404.

👍 1

oliverpool commented 2023-04-15 20:46:23 +02:00

Copy link

I think I found the reason:

the release was created using woodpeckerci/plugin-gitea-release.

This woodpecker plugin does not set the Target field on the CreateReleaseOption struct.

Hence the release gets created with an empty target and the templates behave strangely.

I am quite sure this issue happens on gitea as well (but only for releases created via the API without a

I think I found the reason: the release was created using [`woodpeckerci/plugin-gitea-release`](https://codeberg.org/forgejo-contrib/forgejo-helm/src/commit/78f475de247ee691917f8ff1c53ab14072f63fea/.woodpecker/release-version.yml#L26). This woodpecker plugin does not set the [`Target` field](https://gitea.com/gitea/go-sdk/src/commit/6d1bcd107f2da909bdf92e511efa51049d0df919/gitea/release.go#L99) on the [`CreateReleaseOption` struct](https://codeberg.org/woodpecker-plugins/gitea-release/src/commit/305336f85dfa35fcdf5fed13fc1f83933b4dc8a8/release.go#L75-L81). Hence the release gets created with an empty target and the templates behave strangely. I am quite sure this issue happens on gitea as well (but only for releases created via the API without a

❤️ 1 🚀 1

oliverpool referenced this issue from woodpecker-plugins/gitea-release 2023-04-15 20:57:24 +02:00

Add option for target field #9

oliverpool commented 2023-04-15 21:23:16 +02:00

Copy link

Upstream issue: https://github.com/go-gitea/gitea/issues/24145

Upstream issue: https://github.com/go-gitea/gitea/issues/24145

❤️ 1 🚀 1

6543 commented 2023-04-16 17:41:34 +02:00

Copy link

Plugin pull merged

Plugin pull merged

🚀 1

n0toose added the

s/Forgejo

bug

Codeberg

labels 2023-04-20 19:12:03 +02:00

n0toose commented 2023-04-20 19:13:39 +02:00

Owner

Copy link

Marking this with the "Codeberg" label as this (EDIT: this only concerns Forgejo, still keeping the label) has been reported and fixed upstream. Will close this issue once this bug disappears from Codeberg.

Marking this with the "Codeberg" label as ~~this~~ (EDIT: this only concerns Forgejo, still keeping the label) has been reported *and* fixed upstream. Will close this issue once this bug disappears from Codeberg.

oliverpool commented 2023-04-20 19:26:53 +02:00

Copy link

This is only partially fixed:

• the woodpecker plugin has been fixed (does it need a new release to be usable?), so future releases can specify the target
• however forgejo is still broken when the target is empty - upstream issue, I plan to craft a PR soon, to fix previous releases

This is only partially fixed: - the woodpecker plugin has been fixed (does it need a new release to be usable?), so **future releases** can specify the `target` - however forgejo is still broken when the `target` is empty - [upstream issue](https://github.com/go-gitea/gitea/issues/24145), I plan to craft a PR soon, to fix **previous releases**

viceice commented 2023-04-28 12:47:26 +02:00

Author

Copy link

i think this is fixed in Gitea v1.19.2

• https://github.com/go-gitea/gitea/pull/24197

i think this is fixed in Gitea [`v1.19.2`](https://github.com/go-gitea/gitea/releases/tag/v1.19.2) - https://github.com/go-gitea/gitea/pull/24197

oliverpool commented 2023-04-28 14:13:25 +02:00

Copy link

No, my previous comment is still up-to-date.

No, my previous comment is still up-to-date.

👍 1

oliverpool commented 2023-04-28 14:13:56 +02:00

Copy link

(actually the screenshot of your second post is fixed - not the first one)

(actually the screenshot of your second post is fixed - not the first one)

👍 1

oliverpool commented 2023-05-01 16:59:15 +02:00

Copy link

I just created a PR upstream: https://github.com/go-gitea/gitea/pull/24470

I just created a PR upstream: https://github.com/go-gitea/gitea/pull/24470

❤️ 2 🚀 1

oliverpool commented 2023-05-10 10:25:56 +02:00

Copy link

Upstream PR has been merged into main.

I now need to backport it to 1.19.

Upstream PR has been merged into main. I now need to backport it to 1.19.

❤️ 1 🚀 1

oliverpool commented 2023-05-12 20:22:36 +02:00

Copy link

backport has been merged into release/v1.19 upstream https://github.com/go-gitea/gitea/pull/24659

This should land in Forgejo after the next rebase + release.

backport has been merged into release/v1.19 upstream https://github.com/go-gitea/gitea/pull/24659 This should land in Forgejo after the next rebase + release.

❤️ 1 🚀 1

fnetX closed this issue 2023-10-12 14:57:51 +02:00

n0toose added the

upstream

label 2023-10-13 12:43:16 +02:00

Sign in to join this conversation.

No Branch/Tag specified

Branches Tags

main

No results found.

Labels

Clear labels   

accessibility

Reduces accessibility and is thus a "bug" for certain user groups on Codeberg.

  

bug

Something is not working the way it should. Does not concern outages.

  

bug

infrastructure

Errors evidently caused by infrastructure malfunctions or outages

  

Codeberg

This issue involves Codeberg's downstream modifications and settings and/or Codeberg's structures.

  

contributions welcome

Please join the discussion and consider contributing a PR!

  

docs

No bug, but an improvement to the docs or UI description will help

  

duplicate

This issue or pull request already exists

  

enhancement

New feature

  

infrastructure

Involves changes to the server setups, use `bug/infrastructure` for infrastructure-related user errors.

  

legal

An issue directly involving legal compliance

  

licence / ToS

involving questions about the ToS, especially licencing compliance

  

please chill

we are volunteers

Please consider editing your posts and remember that there is a human on the other side. We get that you are frustrated, but it's harder for us to help you this way.

  

public relations

Things related to Codeberg's external communication

  

question

More information is needed

  

question

user support

This issue contains a clearly stated problem. However, it is not clear whether we have to fix anything on Codeberg's end, but we're helping them fix it and/or find the cause.

  

s/Forgejo

Related to Forgejo. Please also check Forgejo's issue tracker.

  

s/Forgejo/migration

Migration related issues in Forgejo

  

s/Pages

Issues related to the Codeberg Pages feature

  

s/Weblate

Issue is related to the Weblate instance at https://translate.codeberg.org

  

s/Woodpecker

Woodpecker CI related issue

  

security

involves improvements to the sites security

  

service

Add a new service to the Codeberg ecosystem (instead of implementing into Gitea)

  

upstream

An open issue or pull request to an upstream repository to fix this issue (partially or completely) exists (i.e. Gitea, Forgejo, etc.)

  

wontfix

Codeberg's current set of contributors are not planning to spend time on delegating this issue.

No labels

accessibility

bug

bug

infrastructure

Codeberg

contributions welcome

docs

duplicate

enhancement

infrastructure

legal

licence / ToS

please chill

we are volunteers

public relations

question

question

user support

s/Forgejo

s/Forgejo/migration

s/Pages

s/Weblate

s/Woodpecker

security

service

upstream

wontfix

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

4 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Codeberg/Community#967

No description provided.