code review 106380043: cmd/go, cmd/ld, runtime, os/user: TLS emultion for android

src/cmd/ld/elf.c

 // Copyright 2009 The Go Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style
 // license that can be found in the LICENSE file.
 
 #include        "l.h"
 #include        "lib.h"
 #include        "../ld/elf.h"
 
 /*
  * We use the 64-bit data structures on both 32- and 64-bit machines
@@ skipping 758 matching lines @@
         if(sect->vaddr < sect->seg->vaddr + sect->seg->filelen)
                 sh->type = SHT_PROGBITS;
         else
                 sh->type = SHT_NOBITS;
         sh->flags = SHF_ALLOC;
         if(sect->rwx & 1)
                 sh->flags |= SHF_EXECINSTR;
         if(sect->rwx & 2)
                 sh->flags |= SHF_WRITE;
         if(strcmp(sect->name, ".tbss") == 0) {
-                sh->flags |= SHF_TLS;
+                if(strcmp(goos, "android") != 0)

[dave_cheney.net, 2014/07/02 04:33:05]

can you use (HEADTYPE == Handroid) here ? 

[crawshaw, 2014/07/02 14:57:21]

Confusingly, there is no Handroid. I mapped goos of "android" onto Hlinux.
Probably because I am a bad person.

+                        sh->flags |= SHF_TLS; // no TLS on android
                 sh->type = SHT_NOBITS;
         }
         if(linkmode != LinkExternal)
                 sh->addr = sect->vaddr;
         sh->addralign = sect->align;
         sh->size = sect->len;
         sh->off = sect->seg->fileoff + sect->vaddr - sect->seg->vaddr;
 
         return sh;
 }
@@ skipping 726 matching lines @@
                 if(HEADTYPE == Hnetbsd)
                         a += elfwritenetbsdsig();
                 if(HEADTYPE == Hopenbsd)
                         a += elfwriteopenbsdsig();
                 if(buildinfolen > 0)
                         a += elfwritebuildinfo();
         }
         if(a > ELFRESERVE)······
                 diag("ELFRESERVE too small: %lld > %d", a, ELFRESERVE);
 }