BERJAYA

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Side by Side Diff: src/pkg/runtime/asm_tls_android_arm.s

Issue 106380043: code review 106380043: cmd/go, cmd/ld, runtime, os/user: TLS emultion for android (Closed)

Patch Set: diff -r 86b431eeb5c2 https://code.google.com/p/go Created 11 years, 5 months ago

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 // Copyright 2014 The Go Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style

	3 // license that can be found in the LICENSE file.

	4

	5 #include "zasm_GOOS_GOARCH.h"
	minux 2014/07/02 04:21:14 isn't asm_tls_android_arm.s too long? I think tls_ isn't asm_tls_android_arm.s too long? I think tls_android_asm.s is perfectly fine. crawshaw 2014/07/02 14:57:22 Done. Both merged into tls_arm.s. Show quoted text On 2014/07/02 04:21:14, minux wrote: > isn't asm_tls_android_arm.s too long? > I think tls_android_asm.s is perfectly fine. Done. Both merged into tls_arm.s.
	6 #include "funcdata.h"

	7 #include "../../cmd/ld/textflag.h"

	8

	9 // On android, runtime.tlsg is a normal variable.

	10 // TLS offset is computed in x_cgo_inittls.

	11 // See asm_tls_arm.h.

	12

	13 TEXT runtime·save_g(SB),NOSPLIT,$0

	14 MRC 15, 0, R0, C13, C0, 3 // fetch TLS base pointer

	15 MOVW runtime·tlsg(SB), R11

	16 ADD R11, R0

	17 MOVW g, 0(R0)
	minux 2014/07/02 04:21:14 MOVW g, R11<<0(R0) instead of ADD and MOVW. same b MOVW g, R11<<0(R0) instead of ADD and MOVW. same below. (yeah, the plan 9 arm assembler syntax is weird. i hope the new assembler would recognize "R11(R0)") should my nacl/arm changes go in first, you will need to conditionally use the two-instruction sequence just for nacl/arm. crawshaw 2014/07/02 14:57:22 Done. Show quoted text On 2014/07/02 04:21:14, minux wrote: > MOVW g, R11<<0(R0) > instead of ADD and MOVW. > same below. > > (yeah, the plan 9 arm assembler syntax is weird. > i hope the new assembler would recognize "R11(R0)") > > should my nacl/arm changes go in first, you will > need to conditionally use the two-instruction sequence > just for nacl/arm. Done.
	18 RET

	19

	20 TEXT runtime·load_g(SB),NOSPLIT,$0

	21 MRC 15, 0, R0, C13, C0, 3 // fetch TLS base pointer

	22 MOVW runtime·tlsg(SB), R11

	23 ADD R11, R0

	24 MOVW 0(R0), g

	25 RET

OLD	NEW

« src/pkg/runtime/asm_arm.s ('K') | « src/pkg/runtime/asm_arm.s ('k') | src/pkg/runtime/asm_tls_arm.s » ('j') | src/pkg/runtime/asm_tls_arm.s » ('J')