Image Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Image Issue 14682013: Copy BitCodes.h to NaCl/NaClBitCodes.h (Closed)

Created:
7 years, 7 months ago by Karl
Modified:
7 years, 7 months ago
CC:
native-client-reviews_googlegroups.com
Base URL:
http://git.chromium.org/native_client/pnacl-llvm.git@master
Visibility:
Public.

Description

Copy BitCodes.h to NaCl/NaClBitCodes.h Create NaCl specific version of BitCodes.h so that we can custimize it for the PNaCl wire format. Moves enums to namespace naclbitc. Renames classes using NaCl prefix. Fixes references so that files compiles. BUG= https://code.google.com/p/nativeclient/issues/detail?id=3405 [email protected] Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-llvm.git;a=commit;h=7ecb66d

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+252 lines, -246 lines) Patch
Image A + include/llvm/Bitcode/NaCl/NaClBitCodes.h View 1 2 7 chunks +19 lines, -17 lines 0 comments Download
Image M include/llvm/Bitcode/NaCl/NaClBitstreamReader.h View 6 chunks +14 lines, -14 lines 0 comments Download
Image M include/llvm/Bitcode/NaCl/NaClBitstreamWriter.h View 1 16 chunks +31 lines, -31 lines 0 comments Download
Image M include/llvm/Bitcode/NaCl/NaClLLVMBitCodes.h View 1 chunk +2 lines, -4 lines 0 comments Download
Image M lib/Bitcode/NaCl/Reader/NaClBitcodeReader.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
Image M lib/Bitcode/NaCl/Reader/NaClBitstreamReader.cpp View 16 chunks +48 lines, -48 lines 0 comments Download
Image M lib/Bitcode/NaCl/Writer/NaClBitcodeWriter.cpp View 1 14 chunks +136 lines, -130 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Karl
PTAL. Thanks.
7 years, 7 months ago (2013-05-01 20:32:03 UTC) #1
jvoung (off chromium)
LGTM https://codereview.chromium.org/14682013/diff/2001/include/llvm/Bitcode/NaCl/NaClBitCodes.h File include/llvm/Bitcode/NaCl/NaClBitCodes.h (right): https://codereview.chromium.org/14682013/diff/2001/include/llvm/Bitcode/NaCl/NaClBitCodes.h#newcode79 include/llvm/Bitcode/NaCl/NaClBitCodes.h:79: } // End bitc namespace naclbitc
7 years, 7 months ago (2013-05-01 23:41:13 UTC) #2
Karl
https://chromiumcodereview.appspot.com/14682013/diff/2001/include/llvm/Bitcode/NaCl/NaClBitCodes.h File include/llvm/Bitcode/NaCl/NaClBitCodes.h (right): https://chromiumcodereview.appspot.com/14682013/diff/2001/include/llvm/Bitcode/NaCl/NaClBitCodes.h#newcode79 include/llvm/Bitcode/NaCl/NaClBitCodes.h:79: } // End bitc namespace On 2013/05/01 23:41:13, jvoung ...
7 years, 7 months ago (2013-05-02 14:32:14 UTC) #3
Karl
7 years, 7 months ago (2013-05-02 14:32:38 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 manually as r7ecb66d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698