Skip to content

Conversation

@pujagani
Copy link
Contributor

@pujagani pujagani commented Apr 8, 2021

Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Fixes #9009.

Motivation and Context

As described in #9009, the changes update the modifier for wait() method to be accessible to the subclasses and provide a getter for the timeout variable for the same.
The clock variable uses the IClock interface, so making it accessible to subclasses does not allow the use of a subclass specific method, hence instead creating and using a local variable copy will suffice as shown in the tests here https://github.com/SeleniumHQ/selenium/blob/trunk/dotnet/test/support/UI/SlowLoadableComponentTest.cs#L147.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 8, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@diemol diemol added the C-dotnet .NET Bindings label Apr 8, 2021
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@jimevans
Copy link
Member

I'm going to go ahead and close this PR, as it's not complete (doesn't expose the Clock as requested, and doesn't make the Wait method virtual for overriding in subclasses). Commit 5632da3 already contains the changes needed in this PR.

@jimevans jimevans closed this Oct 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-dotnet .NET Bindings

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Modify the SlowLoadableComponent class to be open for extension

3 participants