if opening a file fails, specify whether it was for reading or for writing #384
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iting
Assume a read-only file:
touch foo.json
chmod 400 foo.json
and the Dasel invocation:
dasel put -f foo.json -r json -t string -v Frank 'name.first'
Before this commit, we would get:
Error: could not open file: foo.json: open foo.json: permission denied
leaving the user confused.
Now instead we would get:
Error: could not open file for writing: foo.json: open foo.json: permission denied
^^^^^^^^^^^
helping the user to understand what is happening.
Owner
|
Thanks for the suggestion @marco-m , this is now in the development version and will go out in the next release. |
Owner
|
Hey @marco-m, I thought this was an issue 😵💫 Sorry I didn't base off of your PR |
Author
Don't worry, I always wondered why GitHub had the same numbering for both PRs and issues, this can happen :-) Happy that the idea has been accepted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, thanks for Dasel!
I stumbled upon this minor enhancement to a diagnostic message, so I went away with the PR without opening an issue before.
Assume a read-only file:
and the Dasel invocation:
Before this commit, we would get:
leaving the user confused.
Now instead we would get:
helping the user to understand what is happening.