fix: Ensure proper closing of li element in plugin-editor.php #8937
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
| <ul role="group"> | ||
| <?php wp_print_plugin_file_tree( wp_make_plugin_file_tree( $plugin_editable_files ) ); ?> | ||
| </ul> | ||
| </li> |
There was a problem hiding this comment.
While it makes sense to add this, it won't actually impact the structure of parsed HTML in the DOM. The parsing rules of HTML allow for implicitly-closed LI tags.
Compare the parsed DOM trees:
The only difference is an extra whitespace #text node.
See MDN reference:
Tag omission: The end tag can be omitted if the list item is immediately followed by another
<li>element, or if there is no more content in its parent element.
There was a problem hiding this comment.
Agreed. Also has no real world accessibility consequences, and doesn't violate WCAG as of version 2.2, when the relevant criteria was removed.
However, while no reputable accessibility company would consider it an issue, it is technically required under laws stipulating conformance with WCAG 2.0 or 2.1.
Still worth fixing. We just need to recognize that it's minor.
There was a problem hiding this comment.
Noted. Thank you, @westonruter & @joedolson, for your feedback.
4 participants
This commit ensures that the list item element in the plugin file tree navigation is closed adequately with a tag. The HTML structure in plugin-editor.php now correctly nests the tree structure with proper opening and closing tags.
This improves HTML validity and accessibility compliance for screen readers and other assistive technologies that rely on proper DOM structure, especially important for elements using ARIA roles like "treeitem" and "group".
Trac ticket: https://core.trac.wordpress.org/ticket/63546
Props dkarfa