Skip to content

Improve pdo mysql cleanup #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
KentarouTakeda wants to merge 15 commits into from
Closed

Improve pdo mysql cleanup #2

KentarouTakeda wants to merge 15 commits into from

Conversation

@KentarouTakeda
Copy link

@KentarouTakeda KentarouTakeda commented Nov 11, 2023

Hi, @alexandre-daubois

I have fixed some of the reviews of php#11879 . Could you please merge it?

  • fixed: merge conflict
  • fixed: typo
  • fixed: unnecessary drop table
  • not fixed: Tests that should be split

Regards.

@KentarouTakeda KentarouTakeda mentioned this pull request Nov 11, 2023
Merged
@KentarouTakeda
Copy link
Author

KentarouTakeda commented Nov 11, 2023

It appears that CI is not set up for this pull request. So I ran my repository. (All passed.)

https://github.com/KentarouTakeda/php-src/actions/runs/6831300412?pr=3

@alexandre-daubois alexandre-daubois force-pushed the improve-pdo_mysql-cleanup branch 2 times, most recently from 641b27f to ea4d805 Compare November 15, 2023 13:36
@KentarouTakeda
Copy link
Author

KentarouTakeda commented Nov 15, 2023

Thank you for doing your best.
I'm sorry for doing something unnecessary.

@KentarouTakeda KentarouTakeda deleted the improve-pdo_mysql-cleanup branch November 17, 2023 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Category: Build System Category: Engine Category: Optimizer Extension: bcmath Extension: com_dotnet Extension: ctype Extension: curl Extension: date Extension: dba Extension: dom Extension: exif Extension: ffi Extension: fileinfo Extension: filter Extension: ftp Extension: gd Extension: gettext Extension: hash Extension: iconv Extension: imap Extension: intl Extension: json Extension: ldap Extension: libxml Extension: mbstring Extension: mysqli Extension: mysqlnd Extension: oci8 Extension: odbc Extension: opcache Extension: openssl Extension: pcntl Extension: pcre Extension: pdo (core) Extension: pdo_dblib Extension: pdo_firebird Extension: pdo_mysql Extension: pdo_oci Extension: pdo_odbc Extension: pdo_pgsql Extension: pdo_sqlite Extension: pgsql Extension: phar Extension: random Extension: reflection Extension: session Extension: simplexml Extension: snmp Extension: soap Extension: sockets Extension: sodium Extension: spl Extension: sqlite3 Extension: standard Extension: xml Extension: xmlreader Extension: xmlwriter Extension: xsl Extension: zend_test Extension: zip Extension: zlib SAPI: cgi SAPI: cli SAPI: fpm SAPI: phpdbg

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@KentarouTakeda @alexandre-daubois