allow sublcasses as parameters (#1285)

[dodgex]

see #1285

i started with @PreferenceClick and @PreferenceChange

feel free to hint for other annotations where this would be usefull!

[dodgex]

knowing that it will take some time, i think almost all event binding annotations could benefit from this...

that would allow to use custom classes as parameter without the need to cast.

[WonderCsabo]

Thanks for this contribution!

First, this was assigned to me. Don't take me wrong, i am not "jealous" that you took "my" job, but the opposite! 😉 However, next time can you ping me before start working, to avoid possible parallel work? Luckily, i did not start working on this, yet.

To answer your question: most of the event binding annotations would benefit from this. However i think the @XXXTextChange and @EditorAction annotations really used most of the time with the current class, so we can leave them be. The same applies for @SeekBarXXX and @OptionsItem, but they are little bit more priority then the formers. It would be really good to do the rest. I also think we should implement #1076 (#1076 (comment)) in the same changeset, creating different commits and branches would need more work.

[WonderCsabo]

I do not think this is necessary. The isSubtype() JavaDoc says:

Any type is considered to be a subtype of itself.

[dodgex]

okay. i'll change that

[dodgex]

hey @WonderCsabo. sorry for taking your job! ;) i haven't checked if someone is assigned just if there is a PR... :p

I actually started doing the event binding annotations. as it is (at least until now) a simple task i'll do all of them.

regardig #1076 i think i can add that here too. :)

[WonderCsabo]

Since the extendsType validation passed, at this point typeElement cannot be null.

[WonderCsabo]

Great, thanks!

[dodgex]

@WonderCsabo I'd never forget the JavaDoc... documentation is always the most fun part of coding! :/

[dodgex]

wtf how got the Some newever validation methods forgot to invalidate
commit into this PR :/

[dodgex]

pushed the latest code. sadly have to leave for now.

#1076 has to wait a little. as far as i saw so far, it takes some more time than these small changes. i'll do it but i'm not sure if i can get to it today or if it has to wait for the weekend.

[WonderCsabo]

You rebased onto the wrong commit, and rewrite my first commit. Simply rebase again onto the real develop, and skip the first commit.

[WonderCsabo]

OK, i think i will review this branch as-is then merge, since it already has much commits.

[dodgex]

removed the invalid commit

[dodgex]

i hope i cought all comments.

[WonderCsabo]

I think you are not using this at all.

[WonderCsabo]

This looks really nice. I only have some final comments on a couple of things you missed.

[dodgex]

last two comments adressed. :)

[WonderCsabo]

This is just great. I am sorry but can i ask you to update the wiki later as well?

[dodgex]

duh :/

[dodgex]

wiki updated. i think #1285 can be closed now.

[WonderCsabo]

New doc @PreferenceClick is missing.

[dodgex]

no, i just added it accidently to @PreferenceHeader. fixed the commit

[WonderCsabo]

Wiki merged. Thanks for all your work on this!