Skip to content
This repository was archived by the owner on Feb 26, 2023. It is now read-only.

Conversation

@Bersh
Copy link

@Bersh Bersh commented Nov 4, 2012

Hi!
This is my first pull request so excuse if something wrong.

I've add CustomTitle annotation which allows to specify custom title layout for activity

@pyricau
Copy link
Contributor

pyricau commented Nov 4, 2012

Hi !

Thank you for contributing, it's nice of you. I will have a look at your pull request.

Please note, however, that it would be nice if you could start by posting an issue to discuss the idea and implementation before going directly with a pull request.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes have no relation with the subject of the pull request and doesn't match our coding standards (no wildcard imports).

@Bersh
Copy link
Author

Bersh commented Nov 4, 2012

Thanks for your comments! I'll try to fix it when I'll have free time

@pyricau
Copy link
Contributor

pyricau commented Nov 7, 2012

Ok :) . You'll also notice that we just changed all the packages from com.googlecode.androidannotations to org.androidannotations. You'll need to merge from develop to get those changes. You may have a few conflicts, but hopefully nothing too hard to fix.

@Bersh
Copy link
Author

Bersh commented Nov 19, 2012

At last I managed to fix my changes. I've had some problems with merging, but everything should be fine now. Unfortunately, because of this problems I can see some unneeded commits as added. I've no idea how i can fix it, so excuse me for adding unnecessary commits. My last changes should contains only 17937a0 and 35b94f4 commits

@pyricau
Copy link
Contributor

pyricau commented Nov 19, 2012

Well, if you don't know how to clean a Git history, then better not do it and keep it this way ;) . I'll have a look and merge when I have more time (maybe on thursday).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use it on activities to set a custom layout

@pyricau
Copy link
Contributor

pyricau commented Nov 22, 2012

Other then these two comments, this looks nice. Once you're done, I'll checkout the code, check that everything works fine, and then merge.

@ghost ghost assigned mathieuboniface Jan 29, 2013
@ghost ghost assigned pyricau Feb 28, 2013
pyricau added a commit that referenced this pull request Feb 28, 2013
@pyricau pyricau merged commit f61c956 into androidannotations:develop Feb 28, 2013
@pyricau
Copy link
Contributor

pyricau commented Feb 28, 2013

Doc updated: @CustomTitle

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants