perf($parse): remove getterFn wrapper for internal use

Author: jbedard

src/ng/parse.js

@@ -317,15 +317,7 @@ Lexer.prototype = {
       token.fn = fn;
       token.constant = true;
     } else {
-      var getter = getterFn(ident, this.options, parserText);
-      // TODO(perf): consider exposing the getter reference
-      token.fn = extend(function $parsePathGetter(self, locals) {
-        return getter(self, locals);
-      }, {
-        assign: function(self, value) {
-          return setter(self, ident, value, parserText);
-        }
-      });
+      token.fn = getterFn(ident, this.options, parserText);
     }
 
     this.tokens.push(token);
@@ -413,6 +405,18 @@ Parser.prototype = {
       this.throwError('is an unexpected token', this.tokens[0]);
     }
 
+    //Every value returned must be unique.
+    //If the top most value is shared, such as a getterFn, it must be wrapped
+    if (value.$$parseShared) {
+      var exp = value;
+      value = function $parsedWrapper(self, locals) {
+        return exp(self, locals);
+      };
+      value.assign = exp.assign;
+      value.literal = exp.literal;
+      value.constant = exp.constant;
+    }
+
     value.literal = !!value.literal;
     value.constant = !!value.constant;
 
@@ -935,6 +939,11 @@ function getterFn(path, options, fullExp) {
     var evaledFnGetter = new Function('s', 'l', code); // s=scope, l=locals
     /* jshint +W054 */
     evaledFnGetter.toString = valueFn(code);
+    evaledFnGetter.assign = function(self, value) {
+      return setter(self, path, value, path);
+    };
+    evaledFnGetter.$$parseShared = true;
+
     fn = evaledFnGetter;
   }
 

test/ng/parseSpec.js

@@ -722,7 +722,7 @@ describe('parser', function() {
               scope.$eval('a.toString.constructor = 1', scope);
             }).toThrowMinErr(
                     '$parse', 'isecfn', 'Referencing Function in Angular expressions is disallowed! ' +
-                    'Expression: a.toString.constructor = 1');
+                    'Expression: a.toString.constructor');
           });