CLOUDSTACK-8608: [VMware] System VMs failed to start due to permissions issue. Provide permissions to template folder when mounted on management server. #1875
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@rhtyd Can you run VMware CI on this PR. |
Member
|
@blueorangutan package |
|
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-511 |
Member
|
@blueorangutan test centos7 vmware-55u3 |
|
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-55u3) has been kicked to run smoke tests |
|
Trillian test result (tid-867)
|
Contributor
Author
|
@rhtyd Thanks for running tests. The test failures/errors above are failing in other PRs as well, not related to the changes in this PR. |
Contributor
Author
|
@sateesh-chodapuneedi @rhtyd Please review the changes. |
| s_logger.debug("Set permissions for " + mountPoint); | ||
| String result = null; | ||
| Script script = new Script(true, "chmod", _timeout, s_logger); | ||
| script.add("-R", "0777", mountPoint); |
Contributor
There was a problem hiding this comment.
@sureshanaparti In place of using 0777, I think it is better to declare a constant and use it.
sureshanaparti
commented
Mar 6, 2017
| String result = null; | ||
| final String systemVmTmpltPermissions = "0777"; | ||
| Script script = new Script(true, "chmod", _timeout, s_logger); | ||
| script.add("-R", systemVmTmpltPermissions, mountPoint); |
Contributor
Author
There was a problem hiding this comment.
@SudharmaJain Used the string as suggested instead of hardcoded value for permissions.
Contributor
There was a problem hiding this comment.
@sureshanaparti It would be better if you can move it to TemplateConstants.
Contributor
Author
There was a problem hiding this comment.
@SudharmaJain Moved to TemplateConstants.
Contributor
|
LGTM on the code changes. |
Member
|
LGTM. |
Member
|
LGTM, @sureshanaparti since this is a critical bugfix wher systemvm can fail to start, can you change PR's base branch to 4.9? |
Contributor
Author
|
@rhtyd Changed PR base branch to 4.9. |
Member
|
Thanks @sureshanaparti |
|
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
Packaging result: ✖centos6 ✔centos7 ✔debian. JID-675 |
Member
|
@blueorangutan test centos7 vmware-55u3 |
|
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-55u3) has been kicked to run smoke tests |
|
Trillian test result (tid-1033)
|
Contributor
Author
|
The above intermitten failures are not related to this PR changes. |
…ns issue. Provide permissions to template folder when mounted on management server.
Member
|
@sureshanaparti please rebase/fix the branch |
Member
|
@sureshanaparti ping, can you fix the conflicts? |
Member
|
@sureshanaparti this is marked blocker however no activity or discussion is seen, I'll remove the 'blocker' label and ask the author to engage in a conversation. Thanks. |
Contributor
|
@sureshanaparti please rebase and re-open if still relevant |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[VMware] System VMs failed to start due to permissions issue. Provide permissions to template folder when mounted on management server.
This closes #555