Skip to content

Conversation

@sureshanaparti
Copy link
Contributor

@sureshanaparti sureshanaparti commented May 11, 2017

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

[VMware] Make vCenter session timeout configurable for volume snapshot

  • Split the existing vCenter session timeout configuration into two configurations to ensure that a high timeout value set for snapshot backup operation and will not affect vCenter connections made for any other operations besides volume snapshot.

  • To tune timeout value for CS's session vCenter during snapshot backup operation
    'vmware.snapshot.backup.session.timeout' (new; default: 20 minutes)
    For all other operations - 'vmware.vcenter.session.timeout' (existing; default: 20 minutes)

  • There is a timeout for async-jobs that ensures that any job that has been in process for too long is cancelled. This timeout is configurable using a global configuration ‘job.cancel.threshold.minutes’ and it defaults to 1 hour. For large volumes, even though users configure other snapshot timeout values (‘vmware.snapshot.backup.session.timeout’ and ‘backup.snapshot.wait‘) to a very high value, the snapshot operation will still fail because the job will be cancelled in 1 hour.

  • A new configuration parameter 'volume.snapshot.job.cancel.threshold' has been introduced that will allow admins to separate out the job cancellation timeout for ‘volume snapshot’ jobs from other vm work jobs.

This closes #562

@sureshanaparti sureshanaparti mentioned this pull request May 11, 2017
@sureshanaparti
Copy link
Contributor Author

@borisstoyanov Can you please run vmware tests on this PR.

@sureshanaparti
Copy link
Contributor Author

@sateesh-chodapuneedi @rhtyd Please review the code changes

@sateesh-chodapuneedi
Copy link
Member

@sureshanaparti Can you please resolve the conflicts and rebase?

@rohityadavcloud
Copy link
Member

@sureshanaparti looks like good feature, can you rebase, fix conflicts, move schema change to 4.10->4.11 path?

@rohityadavcloud rohityadavcloud added this to the 4.11 milestone Dec 10, 2017
@rohityadavcloud rohityadavcloud removed this from the 4.11 milestone Jan 4, 2018
@DaanHoogland
Copy link
Contributor

ping @rhtyd do you know if this is still an issue?

@DaanHoogland
Copy link
Contributor

ping all. I will close this one if no activity before 4.15

@Humbedooh Humbedooh closed this Jun 11, 2021
@Humbedooh Humbedooh deleted the branch apache:master June 11, 2021 09:50
@rohityadavcloud
Copy link
Member

Hi, the PR got auto-closed due to no known source repository or some other Github-specific issue during the recent renaming of the default branch to main. If you wish kindly submit a new PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants