React socket change #51
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
May 17, 2017 14:03
Need to be able to test this package on it's own, without requiring some kind of "global" vendor setup.
If this package needs to support php v5.3, then we must lower the phpunit dependency - just to be safe.
Owner
Author
|
Hi Clue Sadly, I have too much workload for the next 2-3 weeks. Therefore, if you can use any of the changes that I have made, please do so - in whatever way you see fit. As mentioned previously, Thanks for your efforts - looking forward to this being released. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In regards to #50, the
StreamingClientTestfails. Having issues mocking a stream class, because it has been marked as final.Not that this is my business - but final classes, private methods, and private properties are considered to be (to some degree) anti-patterns. They make it very hard for other developers to reuse existing implementation and just extend the parts that they need changes in.