Skip to content
This repository was archived by the owner on May 21, 2025. It is now read-only.

Conversation

@nmoinvaz
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Jun 13, 2020

Codecov Report

Merging #277 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master   #277   +/-   ##
=====================================
  Coverage      88%    88%           
=====================================
  Files           2      2           
  Lines           9      9           
=====================================
  Hits            8      8           
  Misses          1      1           

@nmoinvaz
Copy link
Contributor Author

Rebased

@nmoinvaz nmoinvaz changed the title Added ability to skip SSL verification with --no_verify flag. Added ability to skip SSL verification with --no-verify flag. Jun 22, 2020
@thomasrockhu
Copy link
Contributor

@nmoinvaz, apologies remind me of the use case here?

@thomasrockhu thomasrockhu self-requested a review September 8, 2020 19:37
@nmoinvaz
Copy link
Contributor Author

nmoinvaz commented Sep 8, 2020

@Dead2 do you remember why we added this?

@Dead2
Copy link

Dead2 commented Sep 9, 2020

@nmoinvaz It was added because we wanted to proxy the upload through a third-party server, to see whether that fixed our (still-existing) issues with uploads from some CI jobs not working directly to codecov.io (1-4 in every CI run, even with 40+ retries spread over 4 hours).

@thomasrockhu
Copy link
Contributor

@nmoinvaz, I'm likely going to close this out as I don't think this should exist in the uploader. @Dead2, would love your input here as well as I don't think this PR would have helped with the upload issues. More importantly, are you still running into those issues.

@nmoinvaz
Copy link
Contributor Author

nmoinvaz commented Dec 9, 2020

I'm ok with that. We have not had an upload issue in sometime.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants