Convert context menu on element edit page to disclosure menu #12946
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…disclosure menu to "Switch version" (TODO: add translation)
…e code to CP so it works on past revision pages
…CP.js instead of ElementEditor.js
…O add screen reader messages
…new select if was previously on revision select
gcamacho079
added
accessibility 👤
DEV-237 Convert context menus to disclosure-type menus
IMPORTANT: This should only happen on the element pages, not on index pages/tables. This is because they cause a change of context instead of just loading new page content. However, this could also be accomplished by breaking this out two separate select components and adding a "Go" button. |
Contributor
|
@gcamacho079 What is the status of this draft? :) |
Contributor
Author
@marcusgaius, this draft raised some design/UX concerns we’re working through, so this will likely be a Craft 5 update. 👍🏼 |
gcamacho079
deleted the
feature/dev-237-convert-context-menus-to-disclosure-type
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
@brandonkelly marking as a draft because I still need to make changes for this component in the JavaScript.
This is similar to the change we made on element index pages to break the Sort Attribute and Sort Direction into separate form controls, this PR separates Site and Revision/Draft into two separate form controls inside of a disclosure menu.
Related issues