Skip to content

Add newer verison of bootstrap icon #739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
roythearsonist wants to merge 11 commits into from
Closed

Add newer verison of bootstrap icon #739

roythearsonist wants to merge 11 commits into from

Conversation

@roythearsonist
Copy link
Contributor

@roythearsonist roythearsonist commented Jul 9, 2021

Just adds the newer icon. Tell me if I forgot to add something, which I probbably did

dependabot bot and others added 7 commits May 11, 2021 02:39
@dependabot
Bump hosted-git-info from 2.8.8 to 2.8.9
3436ea2 
Bumps [hosted-git-info](https://github.com/npm/hosted-git-info) from 2.8.8 to 2.8.9.
- [Release notes](https://github.com/npm/hosted-git-info/releases)
- [Changelog](https://github.com/npm/hosted-git-info/blob/v2.8.9/CHANGELOG.md)
- [Commits](npm/hosted-git-info@v2.8.8...v2.8.9)

Signed-off-by: dependabot[bot] <[email protected]>
@Thomas-Boi
Merge pull request #603 from devicons/dependabot/npm_and_yarn/hosted-…
563d9cf 
…git-info-2.8.9

Bump hosted-git-info from 2.8.8 to 2.8.9
@dependabot
Bump lodash from 4.17.20 to 4.17.21
c259984 
Bumps [lodash](https://github.com/lodash/lodash) from 4.17.20 to 4.17.21.
- [Release notes](https://github.com/lodash/lodash/releases)
- [Commits](lodash/lodash@4.17.20...4.17.21)

Signed-off-by: dependabot[bot] <[email protected]>
@Thomas-Boi
Merge pull request #604 from devicons/dependabot/npm_and_yarn/lodash-…
7a4ca8a 
…4.17.21

Bump lodash from 4.17.20 to 4.17.21
@Thomas-Boi
Merge pull request #682 from devicons/develop
9f4f5cd 
Release v2.12.0
@roythearsonist
Create bootstrap-original.svg
8b43968 
Newer verison of bootstrap icon
@roythearsonist
Better formatting so you can actually read it
98c39e3
@github-actions

This comment has been minimized.

Sign in to view
@Thomas-Boi
Copy link
Member

Thomas-Boi commented Jul 9, 2021 •
edited
Loading

This looks good @theblobscp. Thank you for updating the icon. I just need you to scale the icon so it matches the viewBox rule as stated by the bot.

@amacado @Panquesito7 should we remove the plain icons? If we do, should someone make a plain version to replace them? The original doesn't look icon friendly

@roythearsonist
Copy link
Contributor Author

roythearsonist commented Jul 9, 2021

Thanks! I'll try to fix it asap

@roythearsonist
Copy link
Contributor Author

roythearsonist commented Jul 9, 2021

I did it but now it looks terrible

@Thomas-Boi
Copy link
Member

Thomas-Boi commented Jul 9, 2021

I did it but now it looks terrible

Unfortunately, adding a viewBox attribute is not enough. You'd have to use the software specified by the bot or scale the elements manually down to fit the viewBox using an SVG editor.

@Thomas-Boi Thomas-Boi changed the base branch from master to develop July 9, 2021 18:35
@roythearsonist
Copy link
Contributor Author

roythearsonist commented Jul 9, 2021

@Thomas-Boi Does this work? If not, what do I need to do? I resized it using the thing from the bot

@Panquesito7 Panquesito7 added the feature:icon PR when a new icon is ready to be added to the collection label Jul 9, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Jul 9, 2021

Hi!

I'm Devicons' SVG-Checker Bot and it seems we have some issues with your SVGs.

Here is what went wrong:

icons/bootstrap/bootstrap-original.svg:
-'viewBox' is not '0 0 128 128' -> Set it or scale the file using https://www.iloveimg.com/resize-image/resize-svg

icons/bootstrap/bootstrap-original.svg:
-'viewBox' is not '0 0 128 128' -> Set it or scale the file using https://www.iloveimg.com/resize-image/resize-svg

For more reference on why these are errors, check out our CONTRIBUTING guide

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

PS. One day, I will be smart enough to fix these errors for you 😣. Until then, I can only point them out.

Panquesito7
Panquesito7 requested changes Jul 9, 2021
View reviewed changes
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may need to make some changes to the icon itself. Also, remember to make the SVG pure SVG format, not using external images or so (that's why the B looks blurry).

@Thomas-Boi
Copy link
Member

Thomas-Boi commented Jul 9, 2021

If you resize the SVG using the web app, just specify the width and height to be 128 in the box specified.

image

You might have to uncheck the Maintain Aspect Ratio box if the SVG is not a square. Any further changes will need an SVG editor

@roythearsonist
Copy link
Contributor Author

roythearsonist commented Jul 10, 2021

If you resize the SVG using the web app, just specify the width and height to be 128 in the box specified.

image

You might have to uncheck the Maintain Aspect Ratio box if the SVG is not a square. Any further changes will need an SVG editor

Ok

@roythearsonist
Copy link
Contributor Author

roythearsonist commented Jul 16, 2021

I'm gonna redo this pr, I kinda messed it up

@roythearsonist roythearsonist deleted the new-bootstrap branch July 16, 2021 20:15
@roythearsonist roythearsonist mentioned this pull request Jul 16, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Panquesito7 Panquesito7 Panquesito7 requested changes

Assignees

No one assigned

Labels

feature:icon PR when a new icon is ready to be added to the collection

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@roythearsonist @Thomas-Boi @Panquesito7