Refactor registry code to be more correct #54
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tianon
force-pushed
the
better-registry-bits
branch
from
41c3722 to
0617c06
Compare
tianon
commented
Nov 3, 2022
tianon
force-pushed
the
better-registry-bits
branch
3 times, most recently
from
f7adb2b to
a3b5702
Compare
Previously, this couldn't fetch from Docker without `DOCKERHUB_PUBLIC_PROXY` (see `registry-1.docker.io` change) and was ignoring content digests. Now it works correctly with or without `DOCKERHUB_PUBLIC_PROXY`, verifies the size of every object it pulls, verifies the digest, _and_ should continue working with the in-progress Moby containerd-integration (where the local image ID becomes the digest of the manifest or index instead of the digest of the config blob as it is today).
tianon
force-pushed
the
better-registry-bits
branch
from
a3b5702 to
5e43968
Compare
Member
Author
Member
|
That seems fine! 🚢 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, this couldn't fetch from Docker without
DOCKERHUB_PUBLIC_PROXY(seeregistry-1.docker.iochange) and was ignoring content digests. Now it works correctly with or withoutDOCKERHUB_PUBLIC_PROXY, verifies the size of every object it pulls, verifies the digest, and should continue working with the in-progress Moby containerd-integration (where the local image ID becomes the digest of the manifest or index instead of the digest of the config blob as it is today).(This also splits the registry code into a separate module so that eventually we could write some kind of tests for it.)