Generic Driver

[ehazlett]

This adds support for a "generic" driver. This is very basic at the moment. Basically you just need an Ubuntu server with SSH. From there it provisions as normal.

[thaJeztah]

Travis is failing

[ehazlett]

I'll check thx

[ehazlett]

Fixed tests.

[hansbogert]

Perhaps the README.md in your branch should elaborate on the generic-driver under the 'Drivers' heading.

[andrewwatson]

Should this driver fail if you try to use it as root? Should it try one thing first that uses sudo to see if it works and then kindly inform the user that all hope is lost if it fails?

[andrewwatson]

this seems like a number of things could go wrong and it would be hard to know what it was... the curl could fail or you might not have sudo permissions...

[ehazlett]

Updated to latest driver spec.

[andrewwatson]

maybe it's just me but when i pull this locally and run "go build" i get a failure:

drivers/openstack/client.go:423: provider.HTTPClient undefined (type *gophercloud.ProviderClient has no field or method HTTPClient)

[ehazlett]

@andrewwatson you need to build with godep -- preferably using script/build

If it still errors then we may need to check the version in Godep

[hairyhenderson]

So... what remains for this to get merged? It'd be awesome if this could be part of 0.3.0 :)

[andrewwatson]

FYI I've been using this driver a lot the past week or so and it seems to
work really well. I've been driving machine from a local-exec provisioner
in terraform and loving it.

On Thu, Apr 30, 2015, 7:11 AM Dave Henderson [email protected]
wrote:

So... what remains for this to get merged? It'd be awesome if this could
be part of 0.3.0 :)

—
Reply to this email directly or view it on GitHub
#406 (comment).

[ehazlett]

@andrewwatson thx for the feedback!

[andrewwatson]

I just submitted a PR to ehazlett/machine for a change to use DialTimeout() but other than that I think this is ready to ship!

[ehazlett]

@nathanleclaire PTAL

[nathanleclaire]

Will do!

[nathanleclaire]

I'm wondering if we might want to trim down the timeout on GetState to ~1 second. Generally for me ls returns in under a second, and with this if you have even one generic host which isn't around any more, your ls runs will take a minimum of 5 seconds. That's pretty long time to just hang at the CLI.

[andrewwatson]

Sounds good to me.

On Tue, May 5, 2015, 12:28 PM Nathan LeClaire [email protected]
wrote:

I'm wondering if we might want to trim down the timeout on GetState to ~1
second. Generally for me ls returns in under a second, and with this if
you have even one generic host which isn't around any more, your ls runs
will take a minimum of 5 seconds. That's pretty long time to just hang at
the CLI.

—
Reply to this email directly or view it on GitHub
#406 (comment).

[ehazlett]

@nathanleclaire rebased and reduced GetState to 1s -- PTAL

[ehazlett]

@nathanleclaire ok i think i hit all of your comments. PTAL. thanks!

[nathanleclaire]

LGTM

[nathanleclaire]

[ehazlett]

@nathanleclaire LMAO

[ehazlett]

@nathanleclaire "Generic is coming..."