Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: dominikh/go-tools
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.2.1
Choose a base ref
...
head repository: dominikh/go-tools
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.2.2
Choose a head ref
  • 10 commits
  • 24 files changed
  • 4 contributors

Commits on Nov 11, 2021

  1. unused: don't ignore fields and methods of aliased type in imported p… 

    …ackage

When ignoring an alias, we don't want to ignore the fields and methods
of the aliased type if that type is in a different package. Not only
is it unnecessary, it also breaks the invariant that we only use
objects we've already seen.

Closes gh-1073

(cherry picked from commit 6c9d8ed)
    @dominikh
    dominikh committed Nov 11, 2021
    Configuration menu
    Copy the full SHA
    40877a4 View commit details
    Browse the repository at this point in the history

  2. SA4000: add exceptions for functions from math/rand 

    Closes gh-1087

(cherry picked from commit c4bd432)
    @dominikh
    dominikh committed Nov 11, 2021
    Configuration menu
    Copy the full SHA
    2659add View commit details
    Browse the repository at this point in the history

  3. S1019: make(map[T]T) and make(map[T]T, 0) are not the same 

    Closes gh-1070

(cherry picked from commit db46980)
    @dominikh
    dominikh committed Nov 11, 2021
    Configuration menu
    Copy the full SHA
    706c608 View commit details
    Browse the repository at this point in the history

  4. go/ir: recognize functions in k8s.io/klog that exit the process 

    This logger has the same exit functions as glog.

Signed-off-by: Stephen Kitt <[email protected]>
Closes: gh-1110 [via git-merge-pr]
(cherry picked from commit f9b753e)
    @skitt @dominikh
    skitt authored and dominikh committed Nov 11, 2021
    Configuration menu
    Copy the full SHA
    f897f3c View commit details
    Browse the repository at this point in the history

  5. go/ir: recognize functions in go.uber.org/zap that exit the process o… 

    …r panic

Closes: gh-1109 [via git-merge-pr]
(cherry picked from commit 8d6bc3a)
    @sebastien-rosset @dominikh
    sebastien-rosset authored and dominikh committed Nov 11, 2021
    Configuration menu
    Copy the full SHA
    f9cde0a View commit details
    Browse the repository at this point in the history

  6. go/ir: add SliceToArrayPointer op 

    This is a backport of golang.org/cl/333749 and golang.org/cl/348511.

Updates: gh-1045
Closes: gh-1081 [via git-merge-pr]
Co-authored-by: Cuong Manh Le <[email protected]>
(cherry picked from commit 61e00c9)
    @dominikh @cuonglm
    dominikh and cuonglm committed Nov 11, 2021
    Configuration menu
    Copy the full SHA
    c8e3104 View commit details
    Browse the repository at this point in the history

  7. analysis/facts/nilness: limit slice to array pointer tests to Go 1.17+ 

    (cherry picked from commit 51b6efb)
    @dominikh
    dominikh committed Nov 11, 2021
    Configuration menu
    Copy the full SHA
    e762e06 View commit details
    Browse the repository at this point in the history

  8. SA1026: reimplement JSON checking using encoding/json rules 

    The previous version of SA1026 was very naive.

- It didn't take addressability into consideration, leading to false positives.
- It didn't cull fields with name conflicts, leading to false positives.
- It didn't traverse into nested structures, leading to false negatives.

The new check is based on a modified copy of encoding/json that
applies all relevant rules.

Updates gh-1088

(cherry picked from commit 467468a)
    @dominikh
    dominikh committed Nov 11, 2021
    Configuration menu
    Copy the full SHA
    3cd9c86 View commit details
    Browse the repository at this point in the history

  9. SA1026, SA5008: reimplement XML checking using encoding/xml rules 

    Same as previous commit, but for XML instead of JSON.

Because we rely on encoding/xml, we can now flag a plethora of invalid
struct tags.

Closes gh-1088

(cherry picked from commit a62bc8e)
    @dominikh
    dominikh committed Nov 11, 2021
    Configuration menu
    Copy the full SHA
    a7f4cb1 View commit details
    Browse the repository at this point in the history

  10. Version 2021.1.2 (v0.2.2)

    @dominikh
    dominikh committed Nov 11, 2021
    Configuration menu
    Copy the full SHA
    c8caa92 View commit details
    Browse the repository at this point in the history
Loading