Support HubMethodNameAttribute inheritance for DefaultHubDispatcher. #64818
+242
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulomorgado
requested review from
BrennanConroy and
halter73
as code owners
dotnet-policy-service
bot
added
the
community-contribution
Contributor
|
Thanks for your PR, @@paulomorgado. Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for inheriting the HubMethodNameAttribute in the DefaultHubDispatcher by modifying the attribute lookup to use inherit: true. This change ensures that when a hub method in a derived class overrides a base class method that has a HubMethodNameAttribute, the attribute is properly inherited.
- Modified
GetCustomAttribute<HubMethodNameAttribute>to useinherit: trueparameter, making it consistent with howAuthorizeAttributeis already handled - Added comprehensive test coverage for
[FromService]attribute functionality with various parameter combinations - Reorganized and added hub test methods in
ServicesHubto support the new tests
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/SignalR/server/Core/src/Internal/DefaultHubDispatcher.cs | Added inherit: true parameter to GetCustomAttribute<HubMethodNameAttribute> call to enable attribute inheritance from base classes |
| src/SignalR/server/SignalR/test/Microsoft.AspNetCore.SignalR.Tests/HubConnectionHandlerTests.cs | Added 10 new test methods for [FromService] attribute scenarios and reorganized using statements |
| src/SignalR/server/SignalR/test/Microsoft.AspNetCore.SignalR.Tests/HubConnectionHandlerTestUtils/Hubs.cs | Added and reorganized hub methods in ServicesHub to support testing of service injection with attributes |
src/SignalR/server/SignalR/test/Microsoft.AspNetCore.SignalR.Tests/HubConnectionHandlerTests.cs
Outdated
Show resolved
Hide resolved
…ests/HubConnectionHandlerTests.cs Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support HubMethodNameAttribute inheritance for DefaultHubDispatcher
Fixes #64291