This repository was archived by the owner on Jan 23, 2023. It is now read-only.
[WIP] Move return blocks out of loops #11192
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Low-tech approach to #9692. Finds forward branches to returns and moves the return block later in the method. Gives better layout in simple cases of search loops that return when they find a result. Won't handle cases where there are multiple non-loop blocks in a loop reachable from just one loop block, or cases where there are non-loop blocks but not returns, say from a `break` or similar construct.
AndyAyersMS
added
* NO MERGE *
Member
Author
|
@dotnet-bot test windows_nt x64 perf |
Member
Author
|
Perf results from above show some promise; left notes over in #9692. |
This was referenced Aug 9, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Low-tech approach to moving return blocks out of loops. PR'ing this just so I can run perf via CI and see if it causes any correctness ripples. No merge.
Doesn't move the returns far enough sometimes, and leaves back to back branches in places, but layout in the various collection
Findmethods looks reasonable.