fix(webfinger): handle domainToASCII in Nodejs & bun

[revathskumar]

In Node.js & Bun, domainToASCII return empty string when hostname with port is given (Eg. localhost:8000).

Fixes: #218

[ThisIsMissEm]

Could you also add a test case for a valid hostname like example.com, but with a port? I'm wondering if that is handled incorrectly at the moment too. The webfinger spec doesn't mention anything about handling ports / domains: https://datatracker.ietf.org/doc/html/rfc7033

This test also doesn't test for what it says it does: https://github.com/fedify-dev/fedify/blame/94721fe927df0cbf105f053783552481b9979e39/src/webfinger/handler.test.ts#L278 (both resources are https: instead of http:, though it does test not found behaviour

[dahlia]

Thank you for reporting #218 and debugging this! As it should be applied to previous versions (1.4.x), I'm going to make a separate patch to fix it.

[revathskumar]

@ThisIsMissEm Added a testcase with http://example.com:8000 for hostname with port.

[ThisIsMissEm]

I think you missed one?

Suggested change

	href: "https://example.org/@someone",
	href: "https://example.org:8000/@someone",

[revathskumar]

@ThisIsMissEm I left it intentionally assuming that it's alternate url and not based on actorUri
for the other testcase "localhost with port", I left it as "example.org".

fedify/src/webfinger/handler.test.ts

Lines 128 to 136 in d3ac8f8

	{
	href: "https://localhost:8000/@someone",
	rel: "http://webfinger.net/rel/profile-page",
	},
	{
	href: "https://example.org/@someone",
	rel: "alternate",
	type: "text/html",
	},

Do I need to make change in both places?

[dahlia]

Fixed in Fedify 1.4.7.