Make buttons in a modal form have proper type. (#25446) (#25478)

denyskon · wxiaoguang · web-flow · commit 050c38ca19cc · 2023-06-24T11:56:06.000+08:00
Backport #25446 by @wxiaoguang Fix #25438 All non-"ok" buttons which do not have "type" should not submit the form, should not be triggered by "Enter". Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
diff --git a/web_src/js/features/common-global.js b/web_src/js/features/common-global.js
@@ -345,6 +345,8 @@ export function initGlobalButtons() {
     if (colorPickers.length > 0) {
       initCompColorPicker();
     }
+    // all non-"ok" buttons which do not have "type" should not submit the form, should not be triggered by "Enter"
+    $($(this).attr('data-modal')).find('form button:not(.ok):not([type])').attr('type', 'button');
   });
 
   $('.delete-post.button').on('click', function (e) {

Original file line number	Diff line number	Diff line change
`@@ -345,6 +345,8 @@ export function initGlobalButtons() {`
`345`	`345`	`if (colorPickers.length > 0) {`
`346`	`346`	`initCompColorPicker();`
`347`	`347`	`}`
	`348`	`+ // all non-"ok" buttons which do not have "type" should not submit the form, should not be triggered by "Enter"`
	`349`	`+ $($(this).attr('data-modal')).find('form button:not(.ok):not([type])').attr('type', 'button');`
`348`	`350`	`});`
`349`	`351`
`350`	`352`	`$('.delete-post.button').on('click', function (e) {`