Skip to content

Commit 18282ab

Browse files
authored
Merge branch 'main' into lunny/fix_missed_migration
2 parents 4034d2c + 0d7cf7b commit 18282ab

File tree

3 files changed

+12
-9
lines changed

3 files changed

+12
-9
lines changed

‎package-lock.json‎

Lines changed: 7 additions & 7 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎package.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@
4343
"vue-bar-graph": "2.0.0",
4444
"vue-loader": "17.0.1",
4545
"vue3-calendar-heatmap": "2.0.0",
46-
"webpack": "5.75.0",
46+
"webpack": "5.76.0",
4747
"webpack-cli": "5.0.1",
4848
"workbox-routing": "6.5.4",
4949
"workbox-strategies": "6.5.4",

‎services/pull/pull.go‎

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -274,9 +274,12 @@ func AddTestPullRequestTask(doer *user_model.User, repoID int64, branch string,
274274
continue
275275
}
276276

277+
// If the PR is closed, someone still push some commits to the PR,
278+
// 1. We will insert comments of commits, but hidden until the PR is reopened.
279+
// 2. We won't send any notification.
277280
AddToTaskQueue(pr)
278281
comment, err := CreatePushPullComment(ctx, doer, pr, oldCommitID, newCommitID)
279-
if err == nil && comment != nil {
282+
if err == nil && comment != nil && !pr.Issue.IsClosed {
280283
notification.NotifyPullRequestPushCommits(ctx, doer, pr, comment)
281284
}
282285
}

0 commit comments

Comments
 (0)