Skip to content

Conversation

@6543
Copy link
Member

@6543 6543 commented May 28, 2020

as title
close perhaps #10690

const maxIssueIDs = 950

@6543 6543 force-pushed the fix_issue-search_10690 branch from 4ee875b to 060c9a8 Compare May 28, 2020 22:41
@CirnoT
Copy link
Contributor

CirnoT commented May 29, 2020

Can we try increasing the limit as per https://github.com/mattn/go-sqlite3#compilation?

CGO_CFLAGS="-DSQLITE_MAX_VARIABLE_NUMBER=32767"

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 29, 2020
@6543
Copy link
Member Author

6543 commented May 30, 2020

Can we try increasing the limit as per https://github.com/mattn/go-sqlite3#compilation?

CGO_CFLAGS="-DSQLITE_MAX_VARIABLE_NUMBER=32767"

Sure it is also a workaround, not sure if it scale :/

@CirnoT
Copy link
Contributor

CirnoT commented May 30, 2020

Should work better than proposed code change in PR and won't affect other database engines.

@6543 6543 deleted the fix_issue-search_10690 branch June 6, 2020 10:58
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants