Use email_address table to check user's email when login with email address #18769
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeripath
reviewed
Feb 14, 2022
GiteaBot
added
the
lgtm/need 2
lunny
force-pushed
the
lunny/fix_ldap
branch
2 times, most recently
from
e7eda2a to
aa4315d
Compare
lunny
force-pushed
the
lunny/fix_ldap
branch
from
5f123d0 to
47ff835
Compare
lunny
changed the title
zeripath
approved these changes
Feb 16, 2022
GiteaBot
added
lgtm/need 1
Contributor
|
I think this is a useful addition (I can now login with different email addresses than the main email address is using local authentication. However, it does not fix #18547 If I set login_source to ldap I'm still not able to login using email, nor using username if the username is not equal to the login_name (Authentication Sign-In Name). this error is logged (i had to switch to more verbose logging): 2022/02/16 23:31:25 ...ers/web/auth/auth.go:200:SignInPost() [I] Failed authentication attempt for johan@xxxx from [::1]:34610: user does not exist [uid: 0, name: johan@xxx, keyid: 0] the same error is shown when I login using my username. I think that the mapping to login_name is just not happening anymore. |
Merged
Member
Author
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not clear what's the problem of the bug, but I think we should get the data from email_address table but not from user table now. It's amazing the test is wrong from 4 years ago.
Fix #18547