Skip to content

Conversation

@andreynering
Copy link
Contributor

Closes #1836

/cc @ethantkoenig

@andreynering andreynering added this to the 1.2.0 milestone Jun 6, 2017
@lafriks
Copy link
Member

lafriks commented Jun 6, 2017

Did you update correctly with fetch command? CI fails with localy modified file error

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 6, 2017
@andreynering
Copy link
Contributor Author

andreynering commented Jun 6, 2017

@lafriks No, I did a go get -u code.gitea.io/git + govendor update +external. I just tried govendor fetch code.gitea.io/git and nothing changed.

/cc @tboerger

@sapk
Copy link
Member

sapk commented Jun 6, 2017

@andreynering I don't have anything to debug. But I think that you may have change in GOPATH that make a different hash and govendor update +external import form GOPATH. govendor fetch may not update from remote because it is the same git commit id ...

Remove folder before or simply govendor remove code.gitea.io/git to force fetch and just do govendor fetch code.gitea.io/git. You should have a different hash in vendor.json.

@sapk
Copy link
Member

sapk commented Jun 6, 2017

And don't hesitate to test make test-vendor locally.

@andreynering
Copy link
Contributor Author

@sapk Thank you for the help.

make test-vendor don't work on Windows, it seems. I tried recloning code.gitea.io/git, updating govendor, etc..., there's no change. 🤔

If no one create a new PR, I'll try on Ubuntu later.

@sapk
Copy link
Member

sapk commented Jun 6, 2017

@andreynering maybe this is related to windows. I will make a PR from a linux os. Sorry for the inconvenience.

@sapk sapk mentioned this pull request Jun 6, 2017
@lunny lunny removed this from the 1.2.0 milestone Jun 7, 2017
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

500 Error after changing the repository branch

5 participants