Skip to content

Don't stack PR tab menu on small screens #25789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lunny merged 16 commits into from
Jul 14, 2023
Merged

Don't stack PR tab menu on small screens #25789

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
b2adf37
Don't stack PR tab menu on small screens
sebastian-sauer Jul 9, 2023
41e88fb
Fix not stackable tabs layout
sebastian-sauer Jul 10, 2023
5b17a53
Merge branch 'main' into bugfix/fix_pr_view_small_screens
GiteaBot Jul 10, 2023
dce1055
Merge branch 'main' into bugfix/fix_pr_view_small_screens
GiteaBot Jul 11, 2023
e8d5a80
Merge branch 'main' into bugfix/fix_pr_view_small_screens
GiteaBot Jul 11, 2023
5489c27
Merge branch 'main' into bugfix/fix_pr_view_small_screens
GiteaBot Jul 11, 2023
560f60c
Merge branch 'main' into bugfix/fix_pr_view_small_screens
GiteaBot Jul 12, 2023
f083595
Merge branch 'main' into bugfix/fix_pr_view_small_screens
GiteaBot Jul 12, 2023
103288f
Merge branch 'main' into bugfix/fix_pr_view_small_screens
GiteaBot Jul 12, 2023
df3d023
Merge branch 'main' into bugfix/fix_pr_view_small_screens
GiteaBot Jul 12, 2023
fc30225
Merge branch 'main' into bugfix/fix_pr_view_small_screens
GiteaBot Jul 12, 2023
c1f3400
Merge branch 'main' into bugfix/fix_pr_view_small_screens
GiteaBot Jul 12, 2023
aa1729e
Merge branch 'main' into bugfix/fix_pr_view_small_screens
GiteaBot Jul 13, 2023
2d7a716
Merge branch 'main' into bugfix/fix_pr_view_small_screens
GiteaBot Jul 13, 2023
0449d19
Merge branch 'main' into bugfix/fix_pr_view_small_screens
GiteaBot Jul 14, 2023
640087f
Merge branch 'main' into bugfix/fix_pr_view_small_screens
GiteaBot Jul 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 24 additions & 21 deletions templates/repo/pulls/tab_menu.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,23 +1,26 @@
<div class="ui top attached pull tabular stackable menu">
<a class="item {{if .PageIsPullConversation}}active{{end}}" href="{{.Issue.Link}}">
{{svg "octicon-comment-discussion"}}
{{$.locale.Tr "repo.pulls.tab_conversation"}}
<span class="ui small label">{{.Issue.NumComments}}</span>
</a>
<a class="item {{if .PageIsPullCommits}}active{{end}}" {{if .NumCommits}}href="{{.Issue.Link}}/commits"{{end}}>
{{svg "octicon-git-commit"}}
{{$.locale.Tr "repo.pulls.tab_commits"}}
<span class="ui small label">{{if .NumCommits}}{{.NumCommits}}{{else}}-{{end}}</span>
</a>
<a class="item {{if .PageIsPullFiles}}active{{end}}" href="{{.Issue.Link}}/files">
{{svg "octicon-diff"}}
{{$.locale.Tr "repo.pulls.tab_files"}}
<span class="ui small label">{{if .NumFiles}}{{.NumFiles}}{{else}}-{{end}}</span>
</a>
<span class="item gt-ml-auto gt-pr-0 gt-font-bold gt-df gt-ac gt-gap-3">
<span><span class="text green">{{if .Diff.TotalAddition}}+{{.Diff.TotalAddition}}{{end}}</span> <span class="text red">{{if .Diff.TotalDeletion}}-{{.Diff.TotalDeletion}}{{end}}</span></span>
<span class="diff-stats-bar">
<div class="diff-stats-add-bar" style="width: {{Eval 100 "*" .Diff.TotalAddition "/" "(" .Diff.TotalAddition "+" .Diff.TotalDeletion "+" 0.0 ")"}}%"></div>
<div class="ui pull tabs container">
<div class="ui top attached pull tabular menu">
<a class="item {{if .PageIsPullConversation}}active{{end}}" href="{{.Issue.Link}}">
{{svg "octicon-comment-discussion"}}
{{$.locale.Tr "repo.pulls.tab_conversation"}}
<span class="ui small label">{{.Issue.NumComments}}</span>
</a>
<a class="item {{if .PageIsPullCommits}}active{{end}}" {{if .NumCommits}}href="{{.Issue.Link}}/commits"{{end}}>
{{svg "octicon-git-commit"}}
{{$.locale.Tr "repo.pulls.tab_commits"}}
<span class="ui small label">{{if .NumCommits}}{{.NumCommits}}{{else}}-{{end}}</span>
</a>
<a class="item {{if .PageIsPullFiles}}active{{end}}" href="{{.Issue.Link}}/files">
{{svg "octicon-diff"}}
{{$.locale.Tr "repo.pulls.tab_files"}}
<span class="ui small label">{{if .NumFiles}}{{.NumFiles}}{{else}}-{{end}}</span>
</a>
<span class="item gt-ml-auto gt-pr-0 gt-font-bold gt-df gt-ac gt-gap-3">
<span><span class="text green">{{if .Diff.TotalAddition}}+{{.Diff.TotalAddition}}{{end}}</span> <span class="text red">{{if .Diff.TotalDeletion}}-{{.Diff.TotalDeletion}}{{end}}</span></span>
<span class="diff-stats-bar">
<div class="diff-stats-add-bar" style="width: {{Eval 100 "*" .Diff.TotalAddition "/" "(" .Diff.TotalAddition "+" .Diff.TotalDeletion "+" 0.0 ")"}}%"></div>
</span>
</span>
</span>
</div>
<div class="ui tabs divider"></div>
</div>
9 changes: 8 additions & 1 deletion web_src/css/repo.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -747,8 +747,15 @@
right: 1px;
}

.repository.view.issue .pull.tabs.container {
width: 100%;
max-width: 100%;
}

.repository.view.issue .pull.tabular.menu {
margin-bottom: 1rem;
margin-bottom: 0;
overflow-x: auto;
overflow-y: hidden;
}

.repository.view.issue .pull.tabular.menu .svg {
Expand Down