Skip to content

Conversation

@wolfogre
Copy link
Member

It seems integration tests require the Gitea binary (maybe use it as git hooks?).

tests.InitTest(true)

If I delete the old binary then make test-sqlite, it will fail. So let integrations.*.test depends on backend.

image

@wolfogre wolfogre added topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Mar 21, 2024
@wolfogre wolfogre added this to the 1.22.0 milestone Mar 21, 2024
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 21, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 21, 2024
@wolfogre
Copy link
Member Author

Give it up, since it seems by design. I noticed that the workflow files sometimes work like "build binary with some tags, but run tests with other tags."

image

@wolfogre wolfogre closed this Mar 21, 2024
@GiteaBot GiteaBot removed this from the 1.22.0 milestone Mar 21, 2024
Copy link
Member

@silverwind silverwind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test, please ignore

@silverwind silverwind requested review from GiteaBot and silverwind and removed request for GiteaBot and silverwind March 25, 2024 18:24
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jun 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm/need 1 This PR needs approval from one additional maintainer to be merged. modifies/internal skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants