Make /users/search return a UserList #4846
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4846 +/- ##
==========================================
+ Coverage 37.31% 37.31% +<.01%
==========================================
Files 305 305
Lines 45194 45188 -6
==========================================
- Hits 16866 16864 -2
+ Misses 25890 25886 -4
Partials 2438 2438
Continue to review full report at Codecov.
|
bkcsoft
added
the
lgtm/need 2
This was referenced Sep 2, 2018
Contributor
Author
|
The opposite solutions are provided by go-gitea/go-sdk#119 and #4847. If these are chosen then this request should be cancelled. |
zeripath
force-pushed
the
Make-Users-Search-Return-A-UserList
branch
from
1b9b39e to
20c85ab
Compare
Contributor
Author
|
This request will require go-gitea/go-sdk#120 to correct the SDK to match. |
Signed-off-by: Andrew Thornton <[email protected]>
zeripath
force-pushed
the
Make-Users-Search-Return-A-UserList
branch
from
20c85ab to
5d92d6c
Compare
Member
|
I think you can close this one since the other solution already have 2 L-GTM. Thanks for the fix. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per issue #4841 . The current implementation of the
/users/searchAPI does not return a UserList but rather an object similar to the SearchResults object returned by/repos/search. This pull request fixes this code to return a UserList as per the API description and the SDK.The issue is that this API has been wrong for at least 10 months - therefore tools may have grown up using the incorrect API. I will also create a pull requests for the opposite solution...