Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: golang/appengine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v2.0.3
Choose a base ref
...
head repository: golang/appengine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v2.0.4
Choose a head ref
  • 3 commits
  • 38 files changed
  • 2 contributors

Commits on Jul 11, 2023

  1. fix: regenerate all protos under new namespace (#314) 

    This should be wire compat as field numbers did not change and
package is not apart of the serialization. I appened `.v2` to each
proto package so that these protos can register distinctly from the
protos that were copied from the v1 library. This removes runtime
errors due to double registration of the same messages. Note: I did
have to specially regenerate taskqueue with a special built version
of protoc-gen-go in order to generate some proto1 legacy message
type that is referenced.

Fixes: #311
Fixes: googleapis/google-cloud-go#7760
    @codyoss
    codyoss authored Jul 11, 2023
    Configuration menu
    Copy the full SHA
    93c9fa1 View commit details
    Browse the repository at this point in the history

  2. Upgrade python version being used by the ci workflow. (#315) 

    * Upgrade python version being used by the ci workflow.

* Update the python version in instance_vm.go.

* Try to fix the v1 gomod test.

* Add export python3 back.

* Stop trying to find python2.7.

* Seems like we still need to install python3.

* There seems to be a mismatch between APPENGINE_DEV_APPSERVER_BINARY and APPENGINE_DEV_APPSERVER.

* Apply the same change to v2 ci.
    @jinglundong
    jinglundong authored Jul 11, 2023
    Configuration menu
    Copy the full SHA
    f96845d View commit details
    Browse the repository at this point in the history

  3. Extend the deadline of a test context to fix a timeout issue. (#316)

    @jinglundong
    jinglundong authored Jul 11, 2023
    Configuration menu
    Copy the full SHA
    d41edd3 View commit details
    Browse the repository at this point in the history
Loading