oauth2: replace a magic number with AuthStyleUnknown

masonelmore · gopherbot · commit 2d34e3091be3 · 2025-04-24T12:19:11.000-07:00
Change-Id: I7e08428b87f141fa6d2932b7d60b3e726a454986 GitHub-Last-Rev: 0aef667 GitHub-Pull-Request: #646 Reviewed-on: https://go-review.googlesource.com/c/oauth2/+/496075 Auto-Submit: Sean Liao <sean@liao.dev> Reviewed-by: Sean Liao <sean@liao.dev> Reviewed-by: David Chase <drchase@google.com> Reviewed-by: Junyang Shao <shaojunyang@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
diff --git a/internal/token.go b/internal/token.go
@@ -216,7 +216,7 @@ func cloneURLValues(v url.Values) url.Values {
 }
 
 func RetrieveToken(ctx context.Context, clientID, clientSecret, tokenURL string, v url.Values, authStyle AuthStyle, styleCache *AuthStyleCache) (*Token, error) {
-	needsAuthStyleProbe := authStyle == 0
+	needsAuthStyleProbe := authStyle == AuthStyleUnknown
 	if needsAuthStyleProbe {
 		if style, ok := styleCache.lookupAuthStyle(tokenURL); ok {
 			authStyle = style

Original file line number	Diff line number	Diff line change
`@@ -216,7 +216,7 @@ func cloneURLValues(v url.Values) url.Values {`
`216`	`216`	`}`
`217`	`217`
`218`	`218`	`func RetrieveToken(ctx context.Context, clientID, clientSecret, tokenURL string, v url.Values, authStyle AuthStyle, styleCache AuthStyleCache) (Token, error) {`
`219`		`- needsAuthStyleProbe := authStyle == 0`
	`219`	`+ needsAuthStyleProbe := authStyle == AuthStyleUnknown`
`220`	`220`	`if needsAuthStyleProbe {`
`221`	`221`	`if style, ok := styleCache.lookupAuthStyle(tokenURL); ok {`
`222`	`222`	`authStyle = style`