Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: grafana/jsonnet-language-server
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.13.0
Choose a base ref
...
head repository: grafana/jsonnet-language-server
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.13.1
Choose a head ref
  • 3 commits
  • 11 files changed
  • 2 contributors

Commits on Aug 24, 2023

  1. Configuration menu
    Copy the full SHA
    9708978 View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2023

  1. Fix world's slowest stack overflow (#123)

    * Fix world's slowest stack overflow
    When dealing with CRDsonnet libraries in our (Grafana Labs) repositories, the language server would lock up:
    
    - I thought it had something to do with CRDsonnet but I was wrong.
    - This happened because it was trying to find a field in the wrong nodestack repeatedly (see image)
    - This PR fixes the issue.
    - Obviously, the language server can't find fields that come from processing jsonschema, but at least it doesn't take up 4 full CPUs (it reached a full 1% CPU usage while testing :) )
    
    * Remove unneeded boolean
    All tests are still passing. `$` can be resolved across multiple files, so I guess the language server is just better now and doesn't need that safety
    If this causes a bug, we should add a new test
    julienduchesne authored Aug 29, 2023
    Configuration menu
    Copy the full SHA
    a23b945 View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2023

  1. Fix double completion bug (#124)

    * Fix double completion bug
    woops
    Closes #122
    
    * One more layer in test
    julienduchesne authored Aug 31, 2023
    Configuration menu
    Copy the full SHA
    aebe161 View commit details
    Browse the repository at this point in the history
Loading