Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: grafana/jsonnet-language-server
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.14.0
Choose a base ref
...
head repository: grafana/jsonnet-language-server
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.14.1
Choose a head ref
  • 2 commits
  • 15 files changed
  • 1 contributor

Commits on Aug 26, 2024

  1. Global cache for documents + top level jsonnet objects (#153) 

    * Global cache for documents + top level jsonnet objects
Closes #133

There are two caches currently:
- One for protocol documents. This one is instantiated by the server and maintained up-to-date as documents are opened, changed, and closed.
- One for jsonnet objects. This one is a global var and is only added to. Modified objects are never removed/modified from the cache.

By merging the two caches, we can expand the first cache's behavior to also invalidate modified objects from the global cache when a document is changed.

* Simplify processing args (#154)

Instead of carrying a `cache` and `vm` around on each function, create a `Processor` struct to contain those

* Fix linting
    @julienduchesne
    julienduchesne authored Aug 26, 2024
    Configuration menu
    Copy the full SHA
    6f0feae View commit details
    Browse the repository at this point in the history

  2. Invalidate the whole "top level objects" cache (#155) 

    ... whenever files are changed. The reason for that is that it's hard to figure out where imports actually lead, so invalidations sometimes won't happen, leading to invalid language server suggestions
    @julienduchesne
    julienduchesne authored Aug 26, 2024
    Configuration menu
    Copy the full SHA
    b2443cf View commit details
    Browse the repository at this point in the history
Loading