Skip to content

Conversation

@kiendang
Copy link
Contributor

@kiendang kiendang commented Aug 5, 2023

We have this in our workflows

on: [push, pull_request]

This is redundant since when someone pushes to a PR branch, it triggers both push and pull_request synchronized which makes the action runs twice. Checking every PR CI and you will see we have the every check run twice (push) and (pull_request).

Just on: push is enough.

@kiendang kiendang requested a review from erikwrede August 5, 2023 16:52
Copy link
Member

@erikwrede erikwrede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I'm not mistaken, the push condition does not apply to forks - that's why the PR trigger is necessary. Setting push to branch Master only should do the trick 😊

@kiendang
Copy link
Contributor Author

kiendang commented Aug 5, 2023

Yup that makes perfect sense.

@syrusakbary
Copy link
Member

This is fixed on main

@syrusakbary syrusakbary closed this Jul 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants