Skip to content

RFC: Client Controlled Nullability Operators Implementation #3281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
twof wants to merge 65 commits into from
Closed

RFC: Client Controlled Nullability Operators Implementation #3281

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
65 commits
Select commit Hold shift + click to select a range
0f45eea
apply old changes on top of up to date main branch
twof Sep 14, 2021
a0c01d3
tests running
twof Sep 14, 2021
d17767d
fixed a couple tests
twof Sep 14, 2021
c44ef34
all tests passing
twof Sep 14, 2021
0155fff
a few additional tests to cover optional cases
twof Sep 14, 2021
c64a6d8
additional tests
twof Sep 15, 2021
44679b4
cleaned up execution tests
twof Sep 16, 2021
eb1561b
add exclusive types tests
twof Sep 19, 2021
9c5a661
corrected executor test name
twof Sep 19, 2021
8e4c735
nonnull fields with aliases tests passing
twof Oct 5, 2021
e7bcecc
revert dependency changes
twof Oct 5, 2021
461e086
remove vscode config
twof Oct 5, 2021
c88fa62
code style fixes
twof Oct 12, 2021
94dce47
resolved errors with executor-test
twof Oct 12, 2021
cbeb96d
fix spelling
twof Oct 12, 2021
33ba3bd
fi some comments to reflect the sections from the spec they implement
twof Nov 2, 2021
f70f0d7
add docs to modifiedOutputType
twof Nov 2, 2021
f84829e
prettier
twof Nov 2, 2021
432499b
list nullability printer tests
twof Nov 10, 2021
7277ec5
Have a more complex required status, and parse it out
twof Nov 10, 2021
e11d5a8
new modifiedOutputType
twof Nov 10, 2021
ddd1d85
more comments
twof Nov 10, 2021
70247d1
parser tests passing
twof Nov 11, 2021
4804aed
printer tests passing
twof Nov 11, 2021
87986c9
cleanup printer test that was being used for debugging
twof Nov 11, 2021
2f6eb4f
new parser tests pass
twof Nov 11, 2021
732554b
errors tell users when they're using unbalenced braces
twof Nov 11, 2021
3af6487
parser tests passing
twof Nov 11, 2021
07d9226
reworked nullability parser to be easier to follow
twof Nov 11, 2021
af6ebc2
handle another case
twof Nov 11, 2021
051c291
first succeeding execution test
twof Nov 11, 2021
73d8164
executor tests pass
twof Nov 16, 2021
d9d34d9
added new rule to deal with required list operator validation
twof Nov 16, 2021
8898a6c
overlapping fields new tests
twof Nov 16, 2021
e0b6ff9
cleanup unused branch in modify type funciton
twof Nov 16, 2021
235026c
cleanup some debugging scratchpad mess
twof Nov 16, 2021
1181aa3
overlapping type cleanup
twof Nov 16, 2021
03c96c7
typeinfo edit passing
twof Nov 17, 2021
d688234
prettier and all tests passing
twof Nov 18, 2021
0f5c158
additional parser tests
twof Nov 18, 2021
ad1df1a
assorted self review cleanup
twof Nov 18, 2021
c5d1cb6
npm test passing
twof Nov 18, 2021
8bb35bd
bring back kind and tokenkind enums
twof Nov 22, 2021
12105c9
lexer updated to hand ?
twof Nov 22, 2021
3d0534e
ds store removed
twof Nov 22, 2021
126198f
Merge branch 'main' into operatorImplementation
twof Nov 23, 2021
22029e6
parser tests passing
twof Nov 24, 2021
0ba98d4
additional cleanup
twof Nov 24, 2021
806fded
reworked how lists are represented in the AST to better capture no-ops
twof Nov 29, 2021
98ceaee
printer tests passing
twof Nov 30, 2021
316cd4b
reworked applyRequiredStatus to use a visitor
twof Nov 30, 2021
2472046
minor cleanup
twof Nov 30, 2021
c1e1812
fixed some of the overlapping fields tests
twof Nov 30, 2021
cb96767
required depth validation fixex
twof Nov 30, 2021
ed2973a
cleanup leftover references to deleted types
twof Nov 30, 2021
546bf3e
complete test coverage
twof Nov 30, 2021
4c4cbf6
all tests passing
twof Nov 30, 2021
002c999
npm test passing
twof Nov 30, 2021
2e3989c
requiring list depth to match type
twof Dec 2, 2021
7715d26
npm test passes
twof Dec 2, 2021
d490d5b
remove node16-only api
twof Dec 7, 2021
6e67e6b
failing test-case found
twof Dec 7, 2021
cc351f4
rework RequiredStatusOnFieldMatchesDefinitionRule so it's not needles…
twof Dec 21, 2021
68701d3
prettier
twof Dec 21, 2021
d15a597
all tests passing and 100% coverage after validation rule update
twof Dec 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions src/__testUtils__/kitchenSinkQuery.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,17 @@ query queryName($foo: ComplexType, $site: Site = MOBILE) @onQuery {
...frag @onFragmentSpread
}
}
field3!
requiredField4: field4!
field5?
optionalField6: field6?
unsetListItemsRequiredList: listField[]!
requiredListItemsUnsetList: listField[!]
requiredListItemsRequiredList: listField[!]!
unsetListItemsOptionalList: listField[]?
optionalListItemsUnsetList: listField[?]
optionalListItemsOptionalList: listField[?]?
multidimensionalList: listField[[[!]!]!]!
}
... @skip(unless: $foo) {
id
Expand Down
Loading