Skip to content

Conversation

@hueitan
Copy link
Owner

@hueitan hueitan commented Jan 4, 2016

No description provided.

@hueitan
Copy link
Owner Author

hueitan commented Jan 4, 2016

hmmm.. this doesn't pass the test. may need more time to look at this.

@hueitan
Copy link
Owner Author

hueitan commented Jan 4, 2016

@Nazanin1369

hueitan pushed a commit that referenced this pull request Jan 4, 2016
Add $compile to output html
@hueitan hueitan merged commit 051e0d5 into master Jan 4, 2016
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it be messageElem.append($compile($validationProvider.getSuccessHTML(messageToShow))(scope));?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Step1: clear the output html => .html('')
Step2: append a new html element => .append(elm)

not a very smart solution but it have no other answers yet 💥

@lvarayut
Copy link
Collaborator

lvarayut commented Jan 4, 2016

Alright. How about messageElem.html($compile($validationProvider.getSuccessHTML(messageToShow))(scope)); ?

@hueitan
Copy link
Owner Author

hueitan commented Jan 4, 2016

@lvarayut I have tried that before 8eb0a6f

It will fail because .html(html_string) accepts only html string, the content is node element after using $compile, so we should use .append() in this case.

@lvarayut
Copy link
Collaborator

lvarayut commented Jan 4, 2016

It just seems a little bit strange at the first glance. BTW. it' worked perfectly 👍

@hueitan
Copy link
Owner Author

hueitan commented Jan 4, 2016

Yes, exactly.

@hueitan
Copy link
Owner Author

hueitan commented Jan 4, 2016

I have added the test case for the compilation, hope we can trust it 😄

@jamhall
Copy link

jamhall commented Jan 5, 2016

Ah great, it's been merged. Thanks guys!

@hueitan
Copy link
Owner Author

hueitan commented Jan 6, 2016

👍 @jamhall You can have your repo up to date.

@hueitan hueitan deleted the compile branch January 8, 2016 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants